Done.
https://bugs.openjdk.java.net/browse/JDK-8226521
/Erik
On 2019-06-19 15:09, Andrew Luo wrote:
Yes, that would be great if you could sponsor.
Thanks,
-Andrew
-Original Message-
From: Erik Joelsson
Sent: Wednesday, June 19, 2019 3:06 PM
To: Andrew Luo ; build-dev@openjdk.java.n
For both java and native source files, we have a feature in the build
which allows overriding based on file name for more specific version
(i.e. OS specific overrides shared). This works quite well and is used
in several locations. It does however break down when building src.zip.
The file with
Fixed.
I also added a dependency for docs-specs-zip in Main.gmk, which I noticed is
necessary to get gensrc to happen (these dependencies are a bit messy, but
that's the status quo).
http://cr.openjdk.java.net/~dlsmith/jdk/8226325/webrev.01
> On Jun 19, 2019, at 12:21 PM, Erik Joelsson wrote:
Looks good from build perspective.
/Erik
On 2019-06-20 11:11, Dan Smith wrote:
Fixed.
I also added a dependency for docs-specs-zip in Main.gmk, which I noticed is
necessary to get gensrc to happen (these dependencies are a bit messy, but
that's the status quo).
http://cr.openjdk.java.net/~d
In a new build configuration, if the user hits tab to complete a make
target before running any other make target, the generated file
find-tests.gmk gets corrupted, causing tons of strange make debug output
to be printed in the console on each subsequent make invocation.
This is caused by the
Erik:
I'm changing TestMake.gmk to accept an
input parameter for a target file to which the list of targets is
printed to instead of stdout. This solves the fundamental design problem.
Sounds good.
Bug: https://bugs.openjdk.java.net/browse/JDK-8226538
Webrev: http://cr.openjdk.java.net/~eri
