Hi David , thanks for forwarding to build-dev + your comments . May I add you
as reviewer?
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8224214.2/
-adjusted the copyright year in make/autoconf/toolchain.m4
-removed the comment as suggested by you
> But that said, if __IBMCPP__
Hi Matthias,
On 30/08/2019 5:55 pm, Baesken, Matthias wrote:
Hi David , thanks for forwarding to build-dev + your comments . May I add you
as reviewer?
Of course.
New webrev :
http://cr.openjdk.java.net/~mbaesken/webrevs/8224214.2/
Updates look good.
Thanks,
David
-
-adjusted t
> On Aug 30, 2019, at 3:55 AM, Baesken, Matthias
> wrote:
>
> Hi David , thanks for forwarding to build-dev + your comments . May I add
> you as reviewer?
>
> New webrev :
>
> http://cr.openjdk.java.net/~mbaesken/webrevs/8224214.2/
Still looks good to me.
Build changes look good.
/Erik
On 2019-08-30 06:33, David Holmes wrote:
Hi Matthias,
On 30/08/2019 5:55 pm, Baesken, Matthias wrote:
Hi David , thanks for forwarding to build-dev + your comments . May
I add you as reviewer?
Of course.
New webrev :
http://cr.openjdk.java.net/~mbaesken/w
Hello,
As noted during the code review of JDK-8229997
(http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062049.html),
for completeness @java.io.Serial annotation should be included on
generated exception types.
Please review the patch below which adds these annotations by upd
Looks good.
/Erik
On 2019-08-30 13:12, Joe Darcy wrote:
Hello,
As noted during the code review of JDK-8229997
(http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062049.html),
for completeness @java.io.Serial annotation should be included on
generated exception types.
Please
On 30/08/2019 21:12, Joe Darcy wrote:
Hello,
As noted during the code review of JDK-8229997
(http://mail.openjdk.java.net/pipermail/core-libs-dev/2019-August/062049.html),
for completeness @java.io.Serial annotation should be included on
generated exception types.
Please review the patch
