JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-11 Thread Simon Tooke
This is a trivial fix that has been sitting around since JDK8.  At one time, 8216354 was marked "won't fix", but I've seen people (including myself) run up against this issue enough that I think it should be addressed.  It's been reopened, and I have a webrev ready that I've tested in the jdk repo

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-11 Thread Erik Joelsson
Looks good. /Erik On 2019-09-11 10:55, Simon Tooke wrote: This is a trivial fix that has been sitting around since JDK8. At one time, 8216354 was marked "won't fix", but I've seen people (including myself) run up against this issue enough that I think it should be addressed.  It's been reopene

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-11 Thread David Holmes
Hi Simon, Erik, I'm a bit confused. Initially 8216354 was reported as already being fixed by 8215445. But the fix proposed here actually reverts a change from 8215445 which means that far from fixing this issue, 8215445 actually introduced it - correct? But 8215445 was only fixed in 13 - no