Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread Simon Tooke
On 9/11/2019 6:07 PM, David Holmes wrote: > Hi Simon, Erik, > > I'm a bit confused. Initially 8216354 was reported as already being > fixed by 8215445. But the fix proposed here actually reverts a change > from 8215445 which means that far from fixing this issue, 8215445 > actually introduced it

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread Erik Joelsson
Hello David, The initial report was about this construct not working at all, as Bash will not expand wildcards inside of quotes: "$with_ucrt_dll_dir/*.dll" In 13 I changed that to remove the quotes to make the statement work at all. The drawback then, as Simon pointed out, was that if $with

RE: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread Langer, Christoph
Hi, I've also played with this already and support Simon's patch. Simon, shall I sponsor it for you? Best regards Christoph > -Original Message- > From: build-dev On Behalf Of Erik > Joelsson > Sent: Donnerstag, 12. September 2019 17:10 > To: David Holmes ; Simon Tooke > ; build-dev >

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread Simon Tooke
On 9/12/2019 4:00 PM, Langer, Christoph wrote: > Hi, > > I've also played with this already and support Simon's patch. > > Simon, shall I sponsor it for you? Yes please, (and thank you).  -Simon > > Best regards > Christoph > >> -Original Message- >> From: build-dev On Behalf Of Erik

Re: JDK 14 RFR: 8216354: Syntax error in toolchain_windows.m4

2019-09-12 Thread David Holmes
Erik, Simon, Thanks for clarifying things. It would have been somewhat clearer if a new bug for the space-in-path problem has been filed rather then reopening the existing issue. Cheers, David On 13/09/2019 1:10 am, Erik Joelsson wrote: Hello David, The initial report was about this constr