Re: How to get a specific tag from Opne jdk source control.

Hi. I just want to clarify it. If I understand you right: 1. when I download b222 - and run "get_source script - I really get source of b222 2. Text - that I get, when run "java -version" - is something that I can set , when running "configure" script Am I right? If so - what is para

Re: How to get a specific tag from Opne jdk source control.

On Sun, 2019-09-22 at 16:06 +0300, Moshe Zuisman wrote: > Hi. > I need to build open JDK jdk8u 222 > > . > I know that I can download precompiled binary distro of this version. But I > need to compile it at our site. > Qu

Re: How to get a specific tag from Opne jdk source control.

On 23/09/2019 6:13 pm, Moshe Zuisman wrote: Hi. I just want to clarify it. If I understand you right: 1. when I download b222 - and run "get_source script - I really get source of b222 Yes. 2. Text - that I get, when run "java -version" - is something that I can set , when running

RFR: 8231351: Add notes for PKCS11 tests in the test doc

Hi all, JBS:https://bugs.openjdk.java.net/browse/JDK-8231351 Webrev: http://cr.openjdk.java.net/~jiefu/8231351-huangjia/webrev.00/ sun/security/pkcs11/Secmod/AddTrustedCert.java failed on Ubuntu 18.04. According to the comments in JDK-8231338, it was caused by the improper NSS libs of the s

Re: RFR: 8231351: Add notes for PKCS11 tests in the test doc

Hi Jia, I think this isn't a general testing problem. It may not worthy of highlighting this point in the JDK testing doc. In fact, PKCS11 tests have their own doc at: test/jdk/sun/security/pkcs11/README Best regards, John Jiang On 2019/9/23 18:04, Jia Huang wrote: Hi all, JBS:    https://bu

Re: RFR: 8231351: Add notes for PKCS11 tests in the test doc

I think this type of comment fits well in the top level test doc. It just provides basic instructions for setting up these tests so that they pass without going into too much detail. Perhaps a reference to the pkcs11 README for more details would be a good idea. Looks good to me. /Erik On 20

RFR: JDK-8210794: Incorrect escaping of $ORIGIN in native test libraries

This patch fixes an escaping issue that causes a broken runpath to be set in test libraries. Bug: https://bugs.openjdk.java.net/browse/JDK-8210794 Webrev: http://cr.openjdk.java.net/~erikj/8210794/webrev.01/index.html /Erik

Re: RFR: JDK-8210794: Incorrect escaping of $ORIGIN in native test libraries

Erik: This patch fixes an escaping issue that causes a broken runpath to be set in test libraries. Bug: https://bugs.openjdk.java.net/browse/JDK-8210794 Webrev: http://cr.openjdk.java.net/~erikj/8210794/webrev.01/index.html Looks good. Tim

Re: RFR: 8231351: Add notes for PKCS11 tests in the test doc

Hi Erik, Thank you for your review and valuable comments. Updated: http://cr.openjdk.java.net/~jiefu/8231351-huangjia/webrev.01/ - The reference to the pkcs11 README and the reviewers had been added. Please note the user in the patch. Hope you wouldn't mind it. Thanks. Could you please sponso

Re: RFR: 8231351: Add notes for PKCS11 tests in the test doc

Hi John Jiang, Thank you for your review. 在 2019年09月23日 20:54, sha.ji...@oracle.com 写道: In fact, PKCS11 tests have their own doc at: test/jdk/sun/security/pkcs11/README I'm afraid most people wouldn't see test/jdk/sun/security/pkcs11/README at all. So it makes very little sense to add the no