Re: RFR: 8233712: Limit default tests jobs based on ulimit -u setting

2019-11-08 Thread Magnus Ihse Bursie
On 2019-11-07 20:48, Severin Gehwolf wrote: Hi Erik, On Thu, 2019-11-07 at 10:01 -0800, Erik Joelsson wrote: Hello Severin, Taking ulimit -u into account does seem like a good idea. I don't see why it needs to be limited to just aarch64 though. It should however be limited to OSes that use uli

Re: RFR: 8233712: Limit default tests jobs based on ulimit -u setting

2019-11-08 Thread Severin Gehwolf
On Fri, 2019-11-08 at 09:58 +0100, Magnus Ihse Bursie wrote: > On 2019-11-07 20:48, Severin Gehwolf wrote: > > Hi Erik, > > > > On Thu, 2019-11-07 at 10:01 -0800, Erik Joelsson wrote: > > > Hello Severin, > > > > > > Taking ulimit -u into account does seem like a good idea. I don't see > > > why

Re: Fixing compiler warnings in src/demo/share/jfc

2019-11-08 Thread Marc Hoffmann
Dear Magnus, as advised I signed the OCA and it was quickly approved (thanks to Dalibor!). I also posted my proposal to swing-dev (https://mail.openjdk.java.net/pipermail/swing-dev/2019-October/009846.html) but with no response so far. Do you have an idea what other strings I can pull to find a

Re: RFR: 8233712: Limit default tests jobs based on ulimit -u setting

2019-11-08 Thread Severin Gehwolf
On Fri, 2019-11-08 at 09:58 +0100, Magnus Ihse Bursie wrote: > On 2019-11-07 20:48, Severin Gehwolf wrote: > > Hi Erik, > > > > On Thu, 2019-11-07 at 10:01 -0800, Erik Joelsson wrote: > > > Hello Severin, > > > > > > Taking ulimit -u into account does seem like a good idea. I don't see > > > why

RFR 8233844: Add LogCompilation build artifacts to .gitignore

2019-11-08 Thread Jorn Vernee
Hi, I'd like to contribute this very small patch that adds some LogCompilation build artifacts to the .gitignore file. Bug: https://bugs.openjdk.java.net/browse/JDK-8233844 Webrev: http://cr.openjdk.java.net/~jvernee/8233844/webrev.00/index.html Testing = manual FWIW, it seems that these art

Re: RFR: 8233712: Limit default tests jobs based on ulimit -u setting

2019-11-08 Thread Severin Gehwolf
> > > > It should be relatively trivial to add this as a required prog in > > basics.m4 and spec.gmk.in. Make sure you only add it as required for > > non-Windows platforms. If you do this, you can change the check in the > > makefile to if $(ULIMIT) has a value, rather than checking on platform. > > Here you go: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8233712/03/webrev/ Hmm, this failed jdk/submit. Could anybody provide me with some details, please? [Mach5] mach5-one-sgehwolf-JDK-8233712-3-20191108-1036-6526715: FAILED Thanks, Severin

Re: RFR: 8233712: Limit default tests jobs based on ulimit -u setting

2019-11-08 Thread Erik Joelsson
ls, please? [Mach5] mach5-one-sgehwolf-JDK-8233712-3-20191108-1036-6526715: FAILED The problem is that when we run tests in our distributed system, we don't run configure on the test node, but instead use the "run-test-prebuilt" make target. For any tool configure needs to disc

Re: RFR 8233844: Add LogCompilation build artifacts to .gitignore

2019-11-08 Thread Erik Joelsson
Hello Jorn, On 2019-11-08 04:24, Jorn Vernee wrote: Hi, I'd like to contribute this very small patch that adds some LogCompilation build artifacts to the .gitignore file. Bug: https://bugs.openjdk.java.net/browse/JDK-8233844 Webrev: http://cr.openjdk.java.net/~jvernee/8233844/webrev.00/index

Re: RFR: 8233712: Limit default tests jobs based on ulimit -u setting

2019-11-08 Thread Severin Gehwolf
quot;. > > > > > > > > It should be relatively trivial to add this as a required prog in > > > > basics.m4 and spec.gmk.in. Make sure you only add it as required for > > > > non-Windows platforms. If you do this, you can change the check in the > >

Re: RFR: 8233712: Limit default tests jobs based on ulimit -u setting

2019-11-08 Thread Erik Joelsson
;s failing already in configure on our Linux hosts. At least on Oracle Linux, it seems ulimit is a bash builtin and not found in path. Configure needs to fallback on that. /Erik Is there some way to reproduce locally? Thanks, Severin [1] [Mach5] mach5-one-sgehwolf-JDK-8233712-4-20191108-14

Re: RFR 8233844: Add LogCompilation build artifacts to .gitignore

2019-11-08 Thread Jorn Vernee
Hello Erik, You are right, I spoke too soon. I deleted the artifacts and tried to trigger the creation by doing a clean build and running some tests, but neither seems to generate the artifacts. I'm really puzzled by this, since I have 4 repos that contain these artifacts (both git and hg), an