Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

2019-11-20 Thread Erik Joelsson
Looks good. /Erik On 2019-11-18 15:28, Mikael Vidstedt wrote: Please review this change which implements the changes for JEP 362: Deprecate the Solaris and SPARC Ports. JBS: https://bugs.openjdk.java.net/browse/JDK-8234370 Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.00/

Re: PING: RFR: 8220074: Clean up GCC 8.3 errors in LittleCMS

2019-11-20 Thread Erik Joelsson
Looks good. /Erik On 2019-11-18 17:34, Yasumasa Suenaga wrote: PING: Could you review it?   JBS: https://bugs.openjdk.java.net/browse/JDK-8220074   webrev: http://cr.openjdk.java.net/~ysuenaga/JDK-8220074/webrev.01/ I think it is a trivial change. Yasumasa On 2019/11/13 11:42, Yasumasa Su

RFR: 8234535: Cross compilation fails due to missing CFLAGS for the BUILD_CC

2019-11-20 Thread christoph . goettschkes
Hi, please review the following change. Bug: https://bugs.openjdk.java.net/browse/JDK-8234535 Webrev: https://cr.openjdk.java.net/~cgo/8234535/webrev.00/ The removed lines are completely out of place and have no use at all. for the CC variable, for instance, the script does the following: CC_O

Re: RFR: 8234370: Implementation of JEP 362: Deprecate the Solaris and SPARC Ports

2019-11-20 Thread Mikael Vidstedt
I noticed that most of the configure options include the default value in the help string (in brackets), so here’s an updated webrev which does exactly that: Webrev: http://cr.openjdk.java.net/~mikael/webrevs/8234370/webrev.01/open/webrev