native debug symbols support on Windows

Hi, I'm currently looking into native debug symbols support for Windows. The OpenJDK build system supports these two configure flags --with-native-debug-symbols= (among a few other options which I don't want to discuss here). So, the name implies that for "internal", debug symbols should be co

RFR(S) : 8228448 : Jconsole can't connect to itself

Hi all, Please review this small patch. Added "-Djdk.attach.allowAttachSelf=true" to jconsole launcher make file. This will allow jconsole to connect to itself. JBS: https://bugs.openjdk.java.net/browse/JDK-8228448 Webrev: http://cr.openjdk.java.net/~vaibhav/8228448/webrev.00/ Testing:

Re: RFR(S) : 8228448 : Jconsole can't connect to itself

Looks good. Erik Hi all, Please review this small patch. Added "-Djdk.attach.allowAttachSelf=true" to jconsole launcher make file. This will allow jconsole to connect to itself. JBS: https://bugs.openjdk.java.net/browse/JDK-8228448 Webrev: http://cr.openjdk.java.net/~vaibhav/8228

Re: native debug symbols support on Windows

Correct, with the Microsoft toolchain there is no support for internal. I don't know what happens to the build if you try to configure it that way. Feel free to come up with a reasonable behavior. /Erik On 2019-12-04 00:06, Langer, Christoph wrote: Hi, I'm currently looking into native debug

Re: RFR(S) : 8228448 : Jconsole can't connect to itself

Looks good. /Erik On 2019-12-04 02:06, Ramkumar Sunderbabu wrote: Hi all, Please review this small patch. Added "-Djdk.attach.allowAttachSelf=true" to jconsole launcher make file. This will allow jconsole to connect to itself. JBS: https://bugs.openjdk.java.net/browse/JDK-8228448

Re: native debug symbols support on Windows

There seems to be an option that will include debug information in generated .obj files. Assuming this option is supported in the versions of Visual Studio we use, it could be used to implement “internal” native debug symbols. /Z7 The /Z7 option produces object files that also contain full sym

Re: native debug symbols support on Windows

Hello, On 2019-12-04 06:26, Bob Vandette wrote: There seems to be an option that will include debug information in generated .obj files. Assuming this option is supported in the versions of Visual Studio we use, it could be used to implement “internal” native debug symbols. /Z7 We already

RE: native debug symbols support on Windows

Hi, thanks for your comments. The reason why I want to have (at least basic) internal debugging information is to have helpful callstacks in hs_err files on crashes. So, Bob, I don't think the executables can contain debug information, just the compiled .obj files. When it comes to linking, th

Re: native debug symbols support on Windows

Oh well, this sentence in [0] says it all. "It is not possible to create an .exe or .dll that contains debug information. Debug information is always placed in a .obj or .pdb file.” I guess you need to copy pdb files if you runtime debug information. Bob. > On Dec 4, 2019, at 10:09 AM, Langer,

Re: native debug symbols support on Windows

On 2019-12-04 07:09, Langer, Christoph wrote: Hi, thanks for your comments. The reason why I want to have (at least basic) internal debugging information is to have helpful callstacks in hs_err files on crashes. We go to rather great length to provide this in our testing. The bundles targ

Re: RFR: 8234835 Use UTF-8 charset in make support Java code

> On Dec 3, 2019, at 5:24 PM, Jonathan Gibbons > wrote: > > Hi Dan, > > I think it's a combination of oral tradition and long-standing precedent. > > Earlier this year, I raised this general issue, partly because of > inconsistent use of -encoding in the build system. The response was that

Re: RFR: 8234835 Use UTF-8 charset in make support Java code

Looks good ... but please add a comment pointing to https://pandoc.org/MANUAL.html """Pandoc uses the UTF-8 character encoding for both input and output.""" On Wed, Dec 4, 2019 at 3:30 PM Dan Smith wrote: > > On Dec 3, 2019, at 5:24 PM, Jonathan Gibbons < > jonathan.gibb...@oracle.com> wrote: >

Re: RFR: 8234835 Use UTF-8 charset in make support Java code

+1 for the change. +1 for Martin's suggestion for an additional comment. -- Jon On 12/4/19 3:52 PM, Martin Buchholz wrote: Looks good ... but please add a comment pointing to https://pandoc.org/MANUAL.html """Pandoc uses the UTF-8 character encoding for both input and output.""" On Wed, Dec

JDK 14 RFR of JDK-8224630: ElementScannerN, N > 9 should scan type parameters

Hello, First on the build front, the -source/-target used in the bootstrap build of langtools was stuck at 9; in the change I'm proposing to update it to 13, the minimum boot JDK: --- old/make/autoconf/boot-jdk.m4    2019-12-04 19:16:42.209000999 -0800 +++ new/make/autoconf/boot-jdk.m4    201