Re: RFR: 8235997: JMH test runner should quote VM_OPTIONS and JAVA_OPTIONS sent to -jvmArgs

2019-12-17 Thread Erik Joelsson
Looks good. /Erik On 2019-12-16 04:27, Claes Redestad wrote: Hi, please review this patch[1] which makes the JMH behave more in line with expectations when adding multiple flags using the VM_OPTIONS and JAVA_OPTIONS control variables. E.g., these fail before the patch: make test TEST=... MIC

Re: RFR: 8235997: JMH test runner should quote VM_OPTIONS and JAVA_OPTIONS sent to -jvmArgs

2019-12-17 Thread Claes Redestad
Thanks, Erik! /Claes On 2019-12-17 12:32, Erik Joelsson wrote: Looks good. /Erik On 2019-12-16 04:27, Claes Redestad wrote: Hi, please review this patch[1] which makes the JMH behave more in line with expectations when adding multiple flags using the VM_OPTIONS and JAVA_OPTIONS control vari

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

2019-12-17 Thread John Paul Adrian Glaubitz
Hi! On 12/16/19 10:08 PM, John Paul Adrian Glaubitz wrote: > On 12/16/19 10:08 PM, Mikael Vidstedt wrote: >> >> I’m not actually sure, but just to be on the safe side I’d prefer to add the >> grouping. > > Okay, will do. Updated revision here: > http://cr.openjdk.java.net/~glaubitz/8235960/web

Re: RFR: 8235960: Zero should not trigger the deprecation warning for ports

2019-12-17 Thread Mikael Vidstedt
Looks good. Cheers, Mikael > On Dec 17, 2019, at 4:24 AM, John Paul Adrian Glaubitz > wrote: > > Hi! > > On 12/16/19 10:08 PM, John Paul Adrian Glaubitz wrote: >> On 12/16/19 10:08 PM, Mikael Vidstedt wrote: >>> >>> I’m not actually sure, but just to be on the safe side I’d prefer to add

RE: building libjvm with -Os for space optimization - was : RE: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-12-17 Thread Baesken, Matthias
Hello, a small update from my side . I had (on Linux) for a couple of days our jdk11u tests + benchmarks running with -Os instead of the usual settings (-O3) . With have (independent of -Os / -O3) a bit of variance in our benchmarks ( jbb15 , jvm2008, jvm98 ) . However the benc

Re: RFR [15] JDK-8235926: Update @jls @jvms taglets to allow inline usage

2019-12-17 Thread Hannes Wallnöfer
Hi Jon, Looks good to me. Hannes > Am 13.12.2019 um 22:21 schrieb Jonathan Gibbons : > > Please review a change to the JDK-specific taglet used to generate links to > the JLS and JVMS specifications. The change is to allow instances of these > tags to be used inline as well as in the series

RE: RE: building libjvm with -Os for space optimization - was : RE: RFR: 8234525: enable link-time section-gc for linux s390x to remove unused code

2019-12-17 Thread Baesken, Matthias
Hi August , thanks for pointing to your webpage, very interesting ! We did our builds+tests/benchmarks with gcc 7.4.0 , what compiler+version did you use? Probably I should look a bit more into Dacapo (we used that one in the past too sometimes). Best regards, Matthias > > I publish