Hello Matthias,
Looks good except for the comment. There is no need to add a comment for
something that has been removed, it will just look confusing.
Documenting it in the JBS issue is enough.
Thanks for cleaning this up!
/Erik
On 2019-12-20 09:37, Baesken, Matthias wrote:
Hello, please
Hello, please review this small MSVC related change .
The MSVC based builds still have the old flag -d2Zi+ set; this is an
undocumented flag , the name of the flag for enhanced optimized debugging is
since VS2013 -Zo .
However the flag (-Zo) is enabled by default for a long time , so the
Hi Erik, thanks for the review ! I'll remove the comment line .
May I get a second review ?
Best regards, Matthias
>
> Hello Matthias,
>
> Looks good except for the comment. There is no need to add a comment for
> something that has been removed, it will just look confusing.
> Documenting
Hi,
I don't think another review is needed, but FWIW this looks good to
me!
/Claes
On 2019-12-20 11:03, Baesken, Matthias wrote:
Hi Erik, thanks for the review ! I'll remove the comment line .
May I get a second review ?
Best regards, Matthias
Hello Matthias,
Looks good except for
Thanks for the reviews !
Best regards, Matthias
>
> Hi,
>
> I don't think another review is needed, but FWIW this looks good to
> me!
>
> /Claes
>
> On 2019-12-20 11:03, Baesken, Matthias wrote:
> > Hi Erik, thanks for the review ! I'll remove the comment line .
> >
> > May I get a
