RE: RFR: 8236714: enable link-time section-gc for linux to remove unused code

2020-01-24 Thread Baesken, Matthias
Hi Erik, thanks for the comments, new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8236714.7/ Best regards, Matthias > Hello, > > That's better, but there are still some issues. > > flags-cflags.m4 > > Code is repeated in both if and else block. > > jdk-options.m4 > > The default

Re: RFR: 8236714: enable link-time section-gc for linux to remove unused code

2020-01-24 Thread Magnus Ihse Bursie
On 2020-01-24 10:27, Baesken, Matthias wrote: Hi Erik, thanks for the comments, new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8236714.7/ Looks good to me. Sorry for not being able to provide an example in a timely matter. Good thing you found one yourself. :) /Magnus Best regard

RE: RFR: 8236714: enable link-time section-gc for linux to remove unused code

2020-01-24 Thread Baesken, Matthias
Thanks for the review ! Erik, are you fine with the latest change too ? Best regards, Matthias > On 2020-01-24 10:27, Baesken, Matthias wrote: > > Hi Erik, thanks for the comments, new webrev : > > > > http://cr.openjdk.java.net/~mbaesken/webrevs/8236714.7/ > Looks good to me. Sorry for not be

RE: RFR: 8237192: Generate stripped/public pdbs on Windows for jdk images

2020-01-24 Thread Baesken, Matthias
Hi Erik, maybe we can just rename the configure option to --enable-stripped-pdbs-for-bundle AND make the default = no/false . Then without setting the configure flag, everything stays as it is for JDK vendors/distributors who do not want the stripped pdbs in the bundle. Others who set the

Re: RFR: 8236714: enable link-time section-gc for linux to remove unused code

2020-01-24 Thread Erik Joelsson
Looks good. /Erik On 2020-01-24 01:27, Baesken, Matthias wrote: Hi Erik, thanks for the comments, new webrev : http://cr.openjdk.java.net/~mbaesken/webrevs/8236714.7/ Best regards, Matthias Hello, That's better, but there are still some issues. flags-cflags.m4 Code is repeated in both