Re: RFR: JDK-8237879: make 4.3 breaks build

2020-01-29 Thread Magnus Ihse Bursie
On 2020-01-28 17:15, Erik Joelsson wrote: On 2020-01-28 03:05, Magnus Ihse Bursie wrote: On 2020-01-28 00:13, Erik Joelsson wrote: Please review this fix to make the build compatible with GNU make 4.3. See bug for details on the fix, but this change basically adds an empty rule like this for t

Re: RFR: JDK-8237879: make 4.3 breaks build

2020-01-29 Thread Erik Joelsson
On 2020-01-29 02:58, Magnus Ihse Bursie wrote: I got tired of the code duplication of "$(call DependOnVariableFileName, $1, $2)". Here's a new webrev with shorter lines, and hopefully better readability overall: http://cr.openjdk.java.net/~ihse/JDK-8237879-make-4-3-include-is-broken/webrev.02/

Re: RFR: JDK-8237879: make 4.3 breaks build

2020-01-29 Thread Tim Bell
Hi Magnus: On 1/29/20 6:01 AM, Erik Joelsson wrote: On 2020-01-29 02:58, Magnus Ihse Bursie wrote: I got tired of the code duplication of "$(call DependOnVariableFileName, $1, $2)". Here's a new webrev with shorter lines, and hopefully better readability overall: http://cr.openjdk.java.net/~

RFR: JDK-8237914: The test-make target does not fail on test failure

2020-01-29 Thread Erik Joelsson
When running the make tests for the build itself, RunTest.gmk currently does not attempt at parsing the results. Because of this, failures aren't detected and so the build does not fail if a test fails. This patch adds a very rudimentary parsing, defining the whole test run as 1 test and succes

Re: RFR: JDK-8237914: The test-make target does not fail on test failure

2020-01-29 Thread Tim Bell
Erik: When running the make tests for the build itself, RunTest.gmk currently does not attempt at parsing the results. Because of this, failures aren't detected and so the build does not fail if a test fails. This patch adds a very rudimentary parsing, defining the whole test run as 1 test an