In JDK-8213184, a rushed revert was pushed to stop breaking CI builds. A
long-term solution is needed, where test-prebuilt can be restored to
jib-profiles.js. This will require the run-test-prebuilt top-level make
target in Help.gmk to be updated as well. Also, Help.gmk should really
change nam
Hi Erik,
thank you for your review and I totally agree with you. It would
definitely be better avoid temp dirs.
I will try to move the creation of the signed image to MacBundles.gmk
and then re-use the SetubBundleFile in Bundles.gmk.
Rene
On Fri, Feb 7, 2020 at 5:19 PM Erik Joelsson wrote:
>
>
The webrev is empty.
/Erik
On 2020-02-10 00:09, Magnus Ihse Bursie wrote:
In JDK-8213184, a rushed revert was pushed to stop breaking CI builds.
A long-term solution is needed, where test-prebuilt can be restored to
jib-profiles.js. This will require the run-test-prebuilt top-level
make targe
Hi Erik,
I have implemented your requested changes. I think it is a lot cleaner
now and the bundling as well as the
signing parts are now only executed when necessary.
New WebRev:
http://cr.openjdk.java.net/~rschuenemann/wr/2020/8238534-macos_sign_bundles/02/
Rene
On Mon, Feb 10, 2020 at 9:23
Hello René,
That looks better. I still have some issues though.
I don't understand line 273 and 305. There is no reason to declare those
rules.
Line 311, the CodeResources file needs prerequisites. Those should be
$(CREATE_JDK_BUNDLE_DIR_SIGNED) (which is the list of all files copied
into t
