Thanks a lot !
--
Lin
>On 2020-02-17 08:48, linzang(臧琳) wrote:
>Hi,
> May I ask help to review one tiny fix of build failure described at
> https://bugs.openjdk.java.net/browse/JDK-8239139
> Root cause is gcc version 8 prints warning for strncpy.
> The fix simply replace strncp
On 2/12/20 6:13 PM, Aleksey Shipilev wrote:
> On 2/12/20 6:00 PM, John Paul Adrian Glaubitz wrote:
>> On 2/12/20 5:59 PM, Aleksey Shipilev wrote:
>>> On 2/12/20 5:54 PM, John Paul Adrian Glaubitz wrote:
I assume I can push with those changes and mark it as Reviewed-by: erikj,
shade?
>>>
Hi Matthias,
Backport looks good to me, too. But please move the new section before
TOOLCHAIN_CFLAGS_JDK_CONLY in make/autoconf/flags-cflags.m4, as suggested by
Andrew. No need for new webrev.
Cheers
Christoph
> -Original Message-
> From: build-dev On Behalf Of
> Andrew John Hughes
>
On 17/02/2020 07:48, linzang(臧琳) wrote:
Hi,
May I ask help to review one tiny fix of build failure described at
https://bugs.openjdk.java.net/browse/JDK-8239139
Root cause is gcc version 8 prints warning for strncpy.
The fix simply replace strncpy with snprintf.
Thanks!
Hi Aleksey!
On 2/17/20 9:07 AM, Aleksey Shipilev wrote:
> On 2/12/20 6:13 PM, Aleksey Shipilev wrote:
>> On 2/12/20 6:00 PM, John Paul Adrian Glaubitz wrote:
>>> On 2/12/20 5:59 PM, Aleksey Shipilev wrote:
On 2/12/20 5:54 PM, John Paul Adrian Glaubitz wrote:
> I assume I can push with tho
Hi Erik,
thanks for your review. While I’ve addressed all your points (thanks for the
great hints regarding usage of SetupCopyFiles), I also enhanced the configure
option a little bit.
What you can now pass is --with-external-symbols-in-bundles=.
Default setting is none. It’ll require --with-n
