Hi,
please review a small fix that updates two comments.
The first one, in make/autoconf/spec.gmk.in, is probably quite old. It talks
about handling of a property "vm.vendor" in VersionProps.java.template.
However, there is no property "vm.vendor", it must rather be "java.vendor". I
stumbled o
From a build perspective this looks fine.
But it seems you are changing the interface for java.lang.System. Don't
you need a CSR for that? Or is your claim that the interface was indeed
changed by JDK-8197927, and it is a bug that the documentation was not
updated to match this?
/Magnus
On
On 3/31/20 7:56 AM, Langer, Christoph wrote:
Hi,
please review a small fix that updates two comments.
The first one, in make/autoconf/spec.gmk.in, is probably quite old. It talks about handling of a property
"vm.vendor" in VersionProps.java.template. However, there is no property "vm.vendor
Hi Magnus,
> From a build perspective this looks fine.
Thanks for the review.
> But it seems you are changing the interface for java.lang.System. Don't
> you need a CSR for that? Or is your claim that the interface was indeed
> changed by JDK-8197927, and it is a bug that the documentation was
Hi Mandy,
this is a good suggestion. The listing of system properties at the props field
declaration seems somewhat redundant, given that it already exists more exactly
and with API normativity in the doc of System::getProperties().
So what do you think of this version:
http://cr.openjdk.java.
