Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

2020-04-06 Thread Amy Lu
Hi, Roger I noticed some other minor cleanup needed, will they be included in this fix, or separately in the future? 1. test/jdk/TEST.groups To remove `sun/tools/java` from core_tools and svc_tools group. (The only one test under `sun/tools/java` got removed in this patch.) 2. doc/building.

Re: RFR 15 8225319: Remove the RMI static stub compiler rmic

2020-04-06 Thread Alan Bateman
On 03/04/2020 16:43, Roger Riggs wrote: Please review the CSR[1] and changes to remove the RMI static stub compiler (rmic). RMIC was deprecated for removal in JDK 13 [3]. The components modified are:  - remove the jdk.rmic module  - remove the jdk.rmic man page  - remove all tests of rmic or

RFR: 8199138: Add RISC-V support to Zero

2020-04-06 Thread John Paul Adrian Glaubitz
Hello! Please review this small change which adds basic support for the riscv64 target for Linux/Zero [1]. I have reduced the complexity of the patch as some of the changes from the previous change set are not necessary, in particular the changes to config.{guess,sub}, the definition of EM_RISCV

Re: RFR: 8199138: Add RISC-V support to Zero

2020-04-06 Thread Erik Joelsson
Build change looks good. /Erik On 2020-04-06 11:09, John Paul Adrian Glaubitz wrote: Hello! Please review this small change which adds basic support for the riscv64 target for Linux/Zero [1]. I have reduced the complexity of the patch as some of the changes from the previous change set are no

Re: RFR: 8199138: Add RISC-V support to Zero

2020-04-06 Thread Thomas Stüfe
Hi Adrian, looks good to me. Cheers, Thomas On Mon, Apr 6, 2020, 20:11 John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > Hello! > > Please review this small change which adds basic support for the riscv64 > target for Linux/Zero [1]. > > I have reduced the complexity of the patc

Re: RFR: 8199138: Add RISC-V support to Zero

2020-04-06 Thread John Paul Adrian Glaubitz
Hello! On 4/6/20 8:09 PM, John Paul Adrian Glaubitz wrote: > I have reduced the complexity of the patch as some of the changes from > the previous change set are not necessary, in particular the changes > to config.{guess,sub}, the definition of EM_RISCV (which is already defined > by the Linux ke

Re: RFR: 8199138: Add RISC-V support to Zero

2020-04-06 Thread Thomas Stüfe
Looks still good. ..Thomas On Tue 7. Apr 2020 at 01:20, John Paul Adrian Glaubitz < glaub...@physik.fu-berlin.de> wrote: > Hello! > > On 4/6/20 8:09 PM, John Paul Adrian Glaubitz wrote: > > I have reduced the complexity of the patch as some of the changes from > > the previous change set are not