Re: RFR(S) : 8240904 : Screen flashes on test failures when running tests from make

On 2020-04-16 19:02, Igor Ignatyev wrote: Hi Erik, sure, I've actually replaced one long statement w/ multiple shorter ones, which made the comment section redundant -- http://cr.openjdk.java.net/~iignatyev//8240904/webrev.01 Looks g

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

On 2020-04-16 18:54, Erik Joelsson wrote: JDK 14 is now GA. The minimum boot JDK version for mainline/JDK 15 should be bumped to this version. Bug: https://bugs.openjdk.java.net/browse/JDK-8242863 Webrev: http://cr.openjdk.java.net/~erikj/8242863/webrev.01/index.html Looks good to me. /Magnu

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

Should the boot JDK's source and target level be updated to 14 as well, so that the interim javac can use JDK 14 features? Or is that automatic? I can still see -source 13 here: https://github.com/openjdk/jdk/blob/07156dd25b0ac468681b33181516bab34bb0c93d/make/autoconf/boot-jdk.m4#L348 Thanks,

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

On 2020-04-17 11:41, Jan Lahoda wrote: Should the boot JDK's source and target level be updated to 14 as well, so that the interim javac can use JDK 14 features? Or is that automatic? I can still see -source 13 here: https://github.com/openjdk/jdk/blob/07156dd25b0ac468681b33181516bab34bb0c93d/

RFR: 8243059: Build fails when --with-vendor-name contains a comma

Hi, Could I please get a review of this build fix? When --with-vendor-name contains a comma, like 'foo, bar, Inc.' the build fails. As it turns out SetupBuildLauncherBody calls SetupJdkExecutable with some parameters. If $(VERSION_CFLAGS) contain a comma, the comma is being treated as a prameter d

Re: RFR: 8243059: Build fails when --with-vendor-name contains a comma

On 2020-04-17 12:18, Severin Gehwolf wrote: Hi, Could I please get a review of this build fix? When --with-vendor-name contains a comma, like 'foo, bar, Inc.' the build fails. As it turns out SetupBuildLauncherBody calls SetupJdkExecutable with some parameters. If $(VERSION_CFLAGS) contain a com

Re: RFR: 8243059: Build fails when --with-vendor-name contains a comma

Hi Magnus, On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote: > On 2020-04-17 12:18, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this build fix? When --with-vendor-name > > contains a comma, like 'foo, bar, Inc.' the build fails. As it turns > > out SetupBuildL

Re: RFR: 8243059: Build fails when --with-vendor-name contains a comma

On 2020-04-17 14:15, Severin Gehwolf wrote: Hi Magnus, On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote: On 2020-04-17 12:18, Severin Gehwolf wrote: Hi, Could I please get a review of this build fix? When --with-vendor-name contains a comma, like 'foo, bar, Inc.' the build fails. A

Re: RFR: 8243059: Build fails when --with-vendor-name contains a comma

On Fri, 2020-04-17 at 14:28 +0200, Magnus Ihse Bursie wrote: > On 2020-04-17 14:15, Severin Gehwolf wrote: > > Hi Magnus, > > > > On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote: > > > On 2020-04-17 12:18, Severin Gehwolf wrote: > > > > Hi, > > > > > > > > Could I please get a review

Re: RFR: 8243059: Build fails when --with-vendor-name contains a comma

This version looks good to me. /Erik On 2020-04-17 05:15, Severin Gehwolf wrote: Hi Magnus, On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote: On 2020-04-17 12:18, Severin Gehwolf wrote: Hi, Could I please get a review of this build fix? When --with-vendor-name contains a comma, l

Re: RFR: 8243059: Build fails when --with-vendor-name contains a comma

On Fri, 2020-04-17 at 07:32 -0700, Erik Joelsson wrote: > This version looks good to me. Thanks for the review, Erik! Cheers, Severin > /Erik > > On 2020-04-17 05:15, Severin Gehwolf wrote: > > Hi Magnus, > > > > On Fri, 2020-04-17 at 13:44 +0200, Magnus Ihse Bursie wrote: > > > On 2020-04-17

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

Good catch Jan! Here is a new webrev where I derive those values from the list of accepted boot jdk versions. http://cr.openjdk.java.net/~erikj/8242863/webrev.02/index.html /Erik On 2020-04-17 02:41, Jan Lahoda wrote: Should the boot JDK's source and target level be updated to 14 as well, s

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

On 2020-04-17 17:13, Erik Joelsson wrote: Good catch Jan! Here is a new webrev where I derive those values from the list of accepted boot jdk versions. http://cr.openjdk.java.net/~erikj/8242863/webrev.02/index.html Looks good to me. /Magnus /Erik On 2020-04-17 02:41, Jan Lahoda wrote:

Re: RFR: JDK-8242863: Bump minimum boot jdk to JDK 14

Looks good to me, Erik! Jan On 17. 04. 20 17:13, Erik Joelsson wrote: Good catch Jan! Here is a new webrev where I derive those values from the list of accepted boot jdk versions. http://cr.openjdk.java.net/~erikj/8242863/webrev.02/index.html /Erik On 2020-04-17 02:41, Jan Lahoda wrote: S