Re: RFR: 8243656: Shell built-in test in configure depends on help

On 2020-05-05 17:15, Severin Gehwolf wrote: Hi, Could I please get a review of this trivial change? Apparently using the help builtin for determining whether or not a builtin is available is not a good idea. A more portable way to do this is to use "command -v" or "type". Thanks to Michael Zucch

Re: RFR: 8243656: Shell built-in test in configure depends on help

On Wed, 2020-05-06 at 10:16 +0200, Magnus Ihse Bursie wrote: > On 2020-05-05 17:15, Severin Gehwolf wrote: > > Hi, > > > > Could I please get a review of this trivial change? Apparently using > > the help builtin for determining whether or not a builtin is available > > is not a good idea. A more

Re: RFR: 8243656: Shell built-in test in configure depends on help

On 2020-05-06 10:52, Severin Gehwolf wrote: On Wed, 2020-05-06 at 10:16 +0200, Magnus Ihse Bursie wrote: On 2020-05-05 17:15, Severin Gehwolf wrote: Hi, Could I please get a review of this trivial change? Apparently using the help builtin for determining whether or not a builtin is available i

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

Hi Mikael, On 2020-05-04 07:12, Mikael Vidstedt wrote: Please review this change which implements part of JEP 381: JBS: https://bugs.openjdk.java.net/browse/JDK-8244224 webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.00/build/open/webrev/ It's a massive change. So you're ge

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

Magnus, thank you so much for the thorough review!! Will send out a new webrev in a bit, meanwhile some comments inline.. > On May 6, 2020, at 4:04 AM, Magnus Ihse Bursie > wrote: > > Hi Mikael, > > On 2020-05-04 07:12, Mikael Vidstedt wrote: >> Please review this change which implements pa

Re: RFR: JDK-8244093 Move all IDE support into coherent structure in make directory

On 4/30/2020 12:28 AM, Jan Lahoda wrote: Hi Brad, This is very similar to what I do. Some small comments inline. On 29. 04. 20 21:02, Bradford Wetmore wrote: Jan, What is your current recommended technique to use NetBeans to build/edit/test OpenJDK for normal OpenJDK library developers?

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

New webrev available here: webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/build/open/webrev/ incremental: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/build.incr/open/webrev