Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

On 2020-05-07 00:52, Mikael Vidstedt wrote: Magnus, thank you so much for the thorough review!! Will send out a new webrev in a bit, meanwhile some comments inline.. On May 6, 2020, at 4:04 AM, Magnus Ihse Bursie > wrote: Hi Mikael, On 2020-05-04 07:1

Re: Faster incremental OpenJDK compilation

On 06. 05. 20 19:23, Jonathan Gibbons wrote: You could refine the imports by filtering them according to whether they are 'star-imports' or the simple name matches a simple name that has been seen by the TreeScanner.  In other words, try and filter out imports that are definitely not relevant.

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

On 2020-05-07 02:47, Mikael Vidstedt wrote: New webrev available here: webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/build/open/webrev/ incremental: http://cr.openjdk.java.net/~mikael/webr

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

> On May 6, 2020, at 8:47 PM, Mikael Vidstedt > wrote: > > > New webrev available here: > > webrev: > http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/build/open/webrev/ > > > incremental: > http:

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

Hi Mikael! On 5/7/20 2:47 AM, Mikael Vidstedt wrote: > New webrev available here: > > webrev: > http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/build/open/webrev/ > > > incremental: > http://cr.open

[8u] RFR(XS): 8243059: Build fails when --with-vendor-name contains a comma

Hi, Could I please get a review of this OpenJDK 8u backport for JDK- 8243059? The build system is wildly different to JDK 11 and later, thus is the patch. In turns out on JDK 8, SetupLauncher isn't using eval() so the evaluation of the comma too early isn't an issue there. However, on JDK 8u, the

RFR: JDK-8244592 Start supporting SOURCE_DATE_EPOCH

As a part of the effort of creating a reproducible build, the build system should know about SOURCE_DATE_EPOCH and allow it to be set using different methods. This fix is needed to unblock JDK-8241616. With this patch, the SOURCE_DATE_EPOCH variable will be available in the environment during

RFR: JDK-8244615 build-performance.m4 is not always parsing /proc/cpuinfo correctly

On some systems the format of /proc/cpuinfo differs from what build-performance.m4 expects. This patch will look for lines beginning with "CPU" if no lines with "processor" is found. Bug: https://bugs.openjdk.java.net/browse/JDK-8244615 Patch inline: diff --git a/make/autoconf/build-performance

Re: RFR: JDK-8244592 Start supporting SOURCE_DATE_EPOCH

Looks good. What tools do we know are picking up this variable today? /Erik On 2020-05-07 07:29, Magnus Ihse Bursie wrote: As a part of the effort of creating a reproducible build, the build system should know about SOURCE_DATE_EPOCH and allow it to be set using different methods. This fix

Re: RFR: JDK-8244615 build-performance.m4 is not always parsing /proc/cpuinfo correctly

Looks good. /Erik On 2020-05-07 08:11, Magnus Ihse Bursie wrote: On some systems the format of /proc/cpuinfo differs from what build-performance.m4 expects. This patch will look for lines beginning with "CPU" if no lines with "processor" is found. Bug: https://bugs.openjdk.java.net/browse/JD

Re: RFR: JDK-8244592 Start supporting SOURCE_DATE_EPOCH

On 2020-05-07 17:34, Erik Joelsson wrote: Looks good. What tools do we know are picking up this variable today? gcc will use it when replacing the __DATE__ and __TIME__ macros. [1] I know of no other tools that use it, but that might just be my limited knowledge. That's the reason I used "upda

Re: RFR: JDK-8241616: Timestamps on ct.sym entries lead to non-reproducible builds

On 2020-04-30 14:50, Jan Lahoda wrote: On 30. 04. 20 14:29, Magnus Ihse Bursie wrote: On 2020-04-30 12:41, Alan Bateman wrote: On 30/04/2020 08:03, Jan Lahoda wrote: Hi, The building of lib/ct.sym is not reproducible, due to timestamps of files inside the file (which is basically a zip fil

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

On 2020-05-07 13:18, John Paul Adrian Glaubitz wrote: Hi Mikael! On 5/7/20 2:47 AM, Mikael Vidstedt wrote: New webrev available here: webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.01/build/open/webrev/

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

Good catch on the deprecation argument! Updated webrev here: webrev: http://cr.openjdk.java.net/~mikael/webrevs/8244224/webrev.02/build/open/webrev/ incremental: http://cr.openjdk.java.net/~mikael/webrevs/824422