Re: RFR: JDK-8244757 Introduce SetupTarget in Main.gmk

2020-05-12 Thread Magnus Ihse Bursie
On 2020-05-11 19:42, Magnus Ihse Bursie wrote: On 2020-05-11 18:16, Magnus Ihse Bursie wrote: To be able to support JDK-8244410, we need to have a better way to handle dependencies. For this reason, the macro SetupTarget is introduced. It will take as input everything that is needed to create

RE: RFR(XS): 8244756: Build broken with some awk version after JDK-8244248

2020-05-12 Thread Baesken, Matthias
Reviewed ! Best regards, Matthias >thank you for proposing a fix which allows building with old awk on AIX. Works >fine. > >Here's the webrev: >http://cr.openjdk.java.net/~mdoerr/8244756_AIX_fix_awk_expr/webrev.00/ >

RE: RFR(XS): 8244756: Build broken with some awk version after JDK-8244248

2020-05-12 Thread Doerr, Martin
Thanks for the reviews! Pushed. Best regards, Martin > -Original Message- > From: Baesken, Matthias > Sent: Dienstag, 12. Mai 2020 11:01 > To: build-dev@openjdk.java.net > Cc: Doerr, Martin > Subject: RE: RFR(XS): 8244756: Build broken with some awk version after JDK- > 8244248 > > >

Re: RFR: JDK-8244757 Introduce SetupTarget in Main.gmk

2020-05-12 Thread Erik Joelsson
On 2020-05-12 00:35, Magnus Ihse Bursie wrote: On 2020-05-11 19:42, Magnus Ihse Bursie wrote: On 2020-05-11 18:16, Magnus Ihse Bursie wrote: To be able to support JDK-8244410, we need to have a better way to handle dependencies. For this reason, the macro SetupTarget is introduced. It will tak

Re: [8u] RFR(XS): 8243059: Build fails when --with-vendor-name contains a comma

2020-05-12 Thread Andrew Haley
On 5/7/20 1:22 PM, Severin Gehwolf wrote: > Bug: https://bugs.openjdk.java.net/browse/JDK-8243059 > webrev: > http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8243059/jdk8/01/webrev/ > > Testing: building with --with-vendor-name="foo, bar". Fails before, > passes after patch. > > Thoughts? OK,

Re: RFR: JDK-8244757 Introduce SetupTarget in Main.gmk

2020-05-12 Thread Magnus Ihse Bursie
On 2020-05-12 14:52, Erik Joelsson wrote: On 2020-05-12 00:35, Magnus Ihse Bursie wrote: On 2020-05-11 19:42, Magnus Ihse Bursie wrote: On 2020-05-11 18:16, Magnus Ihse Bursie wrote: To be able to support JDK-8244410, we need to have a better way to handle dependencies. For this reason, the ma

RFR: JDK-8244844 javac command line is not re-executable

2020-05-12 Thread Magnus Ihse Bursie
We've broken our golden rule in SetupJavaCompilation, that all command lines should be copy/paste:able to re-execute them from the command line. The reason is that the file containing the source code file names has a temporary name, which is renamed after the compilation. This is just a messy w

Re: RFR: JDK-8244844 javac command line is not re-executable

2020-05-12 Thread Erik Joelsson
On 2020-05-12 08:29, Magnus Ihse Bursie wrote: We've broken our golden rule in SetupJavaCompilation, that all command lines should be copy/paste:able to re-execute them from the command line. The reason is that the file containing the source code file names has a temporary name, which is rename

Re: RFR: JDK-8244844 javac command line is not re-executable

2020-05-12 Thread Magnus Ihse Bursie
On 2020-05-12 17:38, Erik Joelsson wrote: On 2020-05-12 08:29, Magnus Ihse Bursie wrote: We've broken our golden rule in SetupJavaCompilation, that all command lines should be copy/paste:able to re-execute them from the command line. The reason is that the file containing the source code file

Re: RFR: JDK-8244844 javac command line is not re-executable

2020-05-12 Thread Erik Joelsson
On 2020-05-12 10:08, Magnus Ihse Bursie wrote: On 2020-05-12 17:38, Erik Joelsson wrote: On 2020-05-12 08:29, Magnus Ihse Bursie wrote: We've broken our golden rule in SetupJavaCompilation, that all command lines should be copy/paste:able to re-execute them from the command line. The reason

Re: RFR: JDK-8244844 javac command line is not re-executable

2020-05-12 Thread Magnus Ihse Bursie
On 2020-05-12 19:17, Erik Joelsson wrote: On 2020-05-12 10:08, Magnus Ihse Bursie wrote: On 2020-05-12 17:38, Erik Joelsson wrote: On 2020-05-12 08:29, Magnus Ihse Bursie wrote: We've broken our golden rule in SetupJavaCompilation, that all command lines should be copy/paste:able to re-exe

Re: RFR: JDK-8244844 javac command line is not re-executable

2020-05-12 Thread Erik Joelsson
Looks good. /Erik On 2020-05-12 10:32, Magnus Ihse Bursie wrote: On 2020-05-12 19:17, Erik Joelsson wrote: On 2020-05-12 10:08, Magnus Ihse Bursie wrote: On 2020-05-12 17:38, Erik Joelsson wrote: On 2020-05-12 08:29, Magnus Ihse Bursie wrote: We've broken our golden rule in SetupJavaCompi

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-12 Thread John Paul Adrian Glaubitz
Hi Mikael! On 5/12/20 12:08 AM, John Paul Adrian Glaubitz wrote: >> Adrian, did you have a chance to look at the zero patch? I’m running out of >> things to >> address and I’m planning on moving forward with the JEP targeting and >> integration shortly. > > I haven't tested the changes by Magnu

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-12 Thread Mikael Vidstedt
Including hotspot-runtime-dev since the zero patch touches hotspot (os_linux) - please review! > On May 12, 2020, at 3:05 PM, John Paul Adrian Glaubitz > wrote: > > Hi Mikael! > > On 5/12/20 12:08 AM, John Paul Adrian Glaubitz wrote: >>> Adrian, did you have a chance to look at the zero pat

Re: RFR: 8244224: Implementation of JEP 381: Remove the Solaris and SPARC Ports (build system)

2020-05-12 Thread David Holmes
On 13/05/2020 8:50 am, Mikael Vidstedt wrote: Including hotspot-runtime-dev since the zero patch touches hotspot (os_linux) - please review! On May 12, 2020, at 3:05 PM, John Paul Adrian Glaubitz wrote: Hi Mikael! On 5/12/20 12:08 AM, John Paul Adrian Glaubitz wrote: Adrian, did you have