LGTM.
Cheers, Thomas
On Sat, May 16, 2020 at 1:34 AM Lemmond, Dan wrote:
> Hi,
>
> This is my first review request so apologies for any missteps or
> inconsistencies.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8244966
> Webrev: http://cr.openjdk.java.net/~phh/8244966/webrev.01/
>
> Pleas
On 2020-05-16 00:57, Yumin Qi wrote:
Hi, Erik
Thanks for test/review.
On 5/15/20 1:48 PM, Erik Joelsson wrote:
I tried a variant of this patch with a 32 bit intel build (server
only to get the cds archive generation enabled). It makes the build
work as expected.
The conditions on line 1
On 2020-05-16 01:06, Lemmond, Dan wrote:
Hi,
This is my first review request so apologies for any missteps or
inconsistencies.
JBS: https://bugs.openjdk.java.net/browse/JDK-8244966
Webrev: http://cr.openjdk.java.net/~phh/8244966/webrev.01/
Please review this change that adds the .vscode direc
On 2020-05-16 00:12, Marc Hoffmann wrote:
Hi Magnus,
I can confirm that this version of the file successfully builds on ARM32 (can’t
speak for other platforms):
https://pici.beachhub.io/#/jdk-marchof/20200515-213321
Thanks for the quick fix!
Thanks Marc. Yumin will push a fix.
/Magnus
-mar
