Looks good to me.
/Magnus
On 2020-05-22 03:54, Kim Barrett wrote:
Please review this change which disables warnings for left shift of a
negative value when compiling HotSpot with gcc or clang. This warning
isn't helpful, given that all compilers seem to do the obvious thing,
and that obvious t
> On May 22, 2020, at 3:38 AM, Magnus Ihse Bursie
> wrote:
>
> Looks good to me.
Thanks.
>
> /Magnus
>
> On 2020-05-22 03:54, Kim Barrett wrote:
>> Please review this change which disables warnings for left shift of a
>> negative value when compiling HotSpot with gcc or clang. This warning
Hi Brad,
Thanks for your review and comments. I'll see if we can indent the
innerclass entries in the header (i.e. option 1) separately.
Jan
On 18. 05. 20 19:47, Bradford Wetmore wrote:
Thanks again Jan for looking into and fixing this.
I looked over the new entries last week, and the new M
http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
> 132 lines changed: 80 ins; 36 del; 16 mod
http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00%2bremoval/
> 57482 lines changed: 80 ins; 57385 del; 17 mod;
Hi all,
could you please review this small (if you ignore removal part) patch w
somehow I forgot to include this although planned:
this patch does *not* change the version of gtest we use in hotspot, that's
to say if you want to build/run gtest tests, the source of gtest-1.8.1 should
be provided to --with-gtest (unless you use jib which would download and pass
source dire
Hello Igor,
The changes look good to me, but I think we should give Magnus a chance
to look at this too.
/Erik
On 2020-05-22 11:12, Igor Ignatyev wrote:
http://cr.openjdk.java.net/~iignatyev/8245610/webrev.00/
132 lines changed: 80 ins; 36 del; 16 mod
http://cr.openjdk.java.net/~iignatyev/
Hi Erik,
thanks for you review. sure, I'll hold up on pushing till Tue's evening, so
Magnus and other will have a chance to look/comment.
-- Igor
> On May 22, 2020, at 11:48 AM, Erik Joelsson wrote:
>
> Hello Igor,
>
> The changes look good to me, but I think we should give Magnus a chance t
