Re: RFR(S) : 8245610 : remove in-tree copy on gtest

2020-05-25 Thread Magnus Ihse Bursie
Looks basically good to me. We need to document the dependency on gtest, and how to retrieve it. I recommend you add a section next to the JTReg information (under the "## Running Tests" heading) in doc/building.md. I think you should include basically the same information as you did in your f

Re: RFR(S) : 8245610 : remove in-tree copy on gtest

2020-05-25 Thread Igor Ignatyev
Hi Magnus, > On May 25, 2020, at 7:46 AM, Magnus Ihse Bursie > wrote: > > Looks basically good to me. thanks for your review! > > We need to document the dependency on gtest, and how to retrieve it. I > recommend you add a section next to the JTReg information (under the "## > Running Tests"