Further testing revealed some issues with the patch, especially:
-use of un-encoded version when deleting the old data for the version
(so the data deletion failed for versions > 9)
-need to delete old module data as well
-when searching for existing methods and fields, we need to continue the
Hi Fedor,
thanks for verifying!
/Claes
On 2020-06-01 10:39, Fedor wrote:
Hi Claes,
The content of classlist files is the same in both cases (before and
after change).
And the change with updated file name $@.classlist => $@.interim as
suggested before.
diff --git
On 2020-06-01 17:54, Claes Redestad wrote:
On 2020-06-01 17:26, Magnus Ihse Bursie wrote:
On 2020-06-01 16:37, Claes Redestad wrote:
Hi,
the classlist generation mutates the interim JDK, which is usually
part of the things we build, but can also be an external bootstrap JDK
that we
On 2020-06-01 20:38, Magnus Ihse Bursie wrote:
http://cr.openjdk.java.net/~redestad/8246256/open.01/
Yes, looks good.
Thanks!
/Claes
Looks good!
/Erik
On 2020-06-01 08:54, Claes Redestad wrote:
On 2020-06-01 17:26, Magnus Ihse Bursie wrote:
On 2020-06-01 16:37, Claes Redestad wrote:
Hi,
the classlist generation mutates the interim JDK, which is usually
part of the things we build, but can also be an external bootstrap
Thanks, Erik!
/Claes
On 2020-06-01 18:04, Erik Joelsson wrote:
Looks good!
/Erik
On 2020-06-01 08:54, Claes Redestad wrote:
On 2020-06-01 17:26, Magnus Ihse Bursie wrote:
On 2020-06-01 16:37, Claes Redestad wrote:
Hi,
the classlist generation mutates the interim JDK, which is usually
On 2020-06-01 16:37, Claes Redestad wrote:
Hi,
the classlist generation mutates the interim JDK, which is usually
part of the things we build, but can also be an external bootstrap JDK
that we shouldn't write to. Fix is to explicitly generate the files to
explicit locations in the build
Hi Magnus,
On Mon, Jun 1, 2020 at 1:35 PM Magnus Ihse Bursie <
magnus.ihse.bur...@oracle.com> wrote:
>
>
> On 2020-05-29 07:04, Thomas Stüfe wrote:
>
> Hi Igor,
>
> thank you for taking the time to answer my grumblings.
>
> Yes, comparison with jtreg is a bit crooked - it is not needed to get a
On 2020-06-01 17:26, Magnus Ihse Bursie wrote:
On 2020-06-01 16:37, Claes Redestad wrote:
Hi,
the classlist generation mutates the interim JDK, which is usually
part of the things we build, but can also be an external bootstrap JDK
that we shouldn't write to. Fix is to explicitly generate
Hi,
the classlist generation mutates the interim JDK, which is usually
part of the things we build, but can also be an external bootstrap JDK
that we shouldn't write to. Fix is to explicitly generate the files to
explicit locations in the build directory.
Sponsoring the fix Fedor suggested
On 2020-05-31 14:39, Yasumasa Suenaga wrote:
Hi all,
I tried to build jdk/jdk on WSL 2 with VS2019, but I saw three errors
as below.
1) Could not detect VC (cl.exe) version. So configure reports that it
could not find valid Microsoft C++ compiler.
2) Could not generate fixpath.exe
On 2020-05-29 07:04, Thomas Stüfe wrote:
Hi Igor,
thank you for taking the time to answer my grumblings.
Yes, comparison with jtreg is a bit crooked - it is not needed to get
a valid build. But jtreg is also maintained in the official OpenJDK
repositories; I can clone codetools/jtreg and
Hi Claes,
The content of classlist files is the same in both cases (before and
after change).
And the change with updated file name $@.classlist => $@.interim as
suggested before.
diff --git a/make/GenerateLinkOptData.gmk b/make/GenerateLinkOptData.gmk
--- a/make/GenerateLinkOptData.gmk
Fix looks good to me then.
Do you need sponsoring help? Is there a bug number for this yet?
/Erik
On 2020-06-01 01:53, Claes Redestad wrote:
Hi Fedor,
thanks for verifying!
/Claes
On 2020-06-01 10:39, Fedor wrote:
Hi Claes,
The content of classlist files is the same in both cases (before
I haven't committers rights so help would be great!
As far as I know there is no bug for described problem yet
Thanks,
Fedor
On 01.06.2020 16:29, Erik Joelsson wrote:
Fix looks good to me then.
Do you need sponsoring help? Is there a bug number for this yet?
/Erik
On 2020-06-01 01:53, Claes
Hi Magnus,
On 2020/06/01 20:06, Magnus Ihse Bursie wrote:
On 2020-05-31 14:39, Yasumasa Suenaga wrote:
Hi all,
I tried to build jdk/jdk on WSL 2 with VS2019, but I saw three errors as below.
1) Could not detect VC (cl.exe) version. So configure reports that it could not
find valid
Ok, I filed a bug and sponsor your patch here:
https://mail.openjdk.java.net/pipermail/build-dev/2020-June/027577.html
Hope you think it looks good. Erik suggested a few line breaks.
Thanks!
/Claes
On 2020-06-01 16:01, Fedor wrote:
I haven't committers rights so help would be great!
As far
17 matches
Mail list logo
