Re: Preliminary review for new WINENV support

2020-07-09 Thread Derek Keeler
After applying Suenaga's patch, I see this error: checking wsl distribution... /home/dekeeler/dev/openjdk.net/sandbox/build/.configure-support/generated-configure.sh: line 32952: -d: command not found I'm running Debian 10 in my WSL2 instance and it does not include `lsb_release` by default. I

cannot find valid Visual Code Studio install

2020-07-09 Thread Ty Young
Hopefully this is the right place. Don't shoot me if it isn't, please. I'm trying to build the JDK from Windows 10. I got so far as to configure failing on finding what it needs from the Visual Code Studio install via command line: configure: Found Visual Studio installation at /cygdrive/c/

Re: cannot find valid Visual Code Studio install

2020-07-09 Thread Erik Joelsson
Hello Ty, Microsoft Visual Studio 2019 or 2017, any edition, should work. My best guess is that you skipped installing the necessary parts of it. Run the installer again, click "Modify" and make sure you have "Desktop development with C++" ticked in. /ERik On 2020-07-09 01:29, Ty Young wrot

Re: cannot find valid Visual Code Studio install

2020-07-09 Thread Ty Young
On 7/9/20 7:37 AM, Erik Joelsson wrote: Hello Ty, Microsoft Visual Studio 2019 or 2017, any edition, should work. My best guess is that you skipped installing the necessary parts of it. Run the installer again, click "Modify" and make sure you have "Desktop development with C++" ticked in.

Re: cannot find valid Visual Code Studio install

2020-07-09 Thread Erik Joelsson
Could you post the full configure command and log please. This sounds weird. You should not be needing clang on Windows. Also, what source did you clone? /Erik On 2020-07-09 07:04, Ty Young wrote: On 7/9/20 7:37 AM, Erik Joelsson wrote: Hello Ty, Microsoft Visual Studio 2019 or 2017, any e

Re: cannot find valid Visual Code Studio install

2020-07-09 Thread Ty Young
On 7/9/20 9:22 AM, Erik Joelsson wrote: Could you post the full configure command and log please. This sounds weird. You should not be needing clang on Windows. Also, what source did you clone? On linux right now, but I think it's because I'm using the jextract branch of panama-foreign:

Re: cannot find valid Visual Code Studio install

2020-07-09 Thread Erik Joelsson
On 2020-07-09 12:56, Ty Young wrote: On 7/9/20 9:22 AM, Erik Joelsson wrote: Could you post the full configure command and log please. This sounds weird. You should not be needing clang on Windows. Also, what source did you clone? On linux right now, but I think it's because I'm using th

Re: cannot find valid Visual Code Studio install

2020-07-09 Thread Ty Young
On 7/9/20 3:20 PM, Erik Joelsson wrote: On 2020-07-09 12:56, Ty Young wrote: On 7/9/20 9:22 AM, Erik Joelsson wrote: Could you post the full configure command and log please. This sounds weird. You should not be needing clang on Windows. Also, what source did you clone? On linux right

Re: cannot find valid Visual Code Studio install

2020-07-09 Thread Peter Levart
Don't know much about build system but the following caught my eye: On 7/10/20 12:04 AM, Ty Young wrote: c1xx: fatal error C1083: Cannot open source file: '../../../..c:/cygwin64/home/young/jdk-master/jdk-master/build/windows-x86_64-server-release/hotspot/variant-server/libjvm/objs/BUILD_LIBJVM