Re: [OpenJDK 2D-Dev] RFR (XS) 8250605: Linux x86_32 builds fail after JDK-8249821

2020-07-28 Thread Aleksey Shipilev
On 7/27/20 6:53 PM, Philip Race wrote: > OK .. although I hope to come back in JDK 16 and eliminate all disabled > warnings > from the now much smaller libfontmanager : > https://bugs.openjdk.java.net/browse/JDK-8074844 OK, pushed. -- Thanks, -Aleksey

[15] RFR(T) : 8250688 : missed open parenthesis for GTEST_FRAMEWORK_SRC var in Main.gmk

2020-07-28 Thread Igor Ignatyev
> 1 files changed, 1 insertions(+), 1 deletions(-) Hi all, could you please review the one-liner which fixes the typo introduced by 8245610? patch: > diff -r 31a8f79a7dfe make/Main.gmk > --- a/make/Main.gmk Tue Jul 28 10:32:57 2020 -0400 > +++ b/make/Main.gmk Tue Jul 28 07:50:42 2020 -0700

Re: [15] RFR(T) : 8250688 : missed open parenthesis for GTEST_FRAMEWORK_SRC var in Main.gmk

2020-07-28 Thread Erik Joelsson
Looks good. /Erik On 2020-07-28 07:51, Igor Ignatyev wrote: 1 files changed, 1 insertions(+), 1 deletions(-) Hi all, could you please review the one-liner which fixes the typo introduced by 8245610? patch: diff -r 31a8f79a7dfe make/Main.gmk --- a/make/Main.gmk Tue Jul 28 10:32:57 2020

Re: [15] RFR(T) : 8250688 : missed open parenthesis for GTEST_FRAMEWORK_SRC var in Main.gmk

2020-07-28 Thread Igor Ignatyev
thanks Erik, pushed to jdk15. -- Igor > On Jul 28, 2020, at 8:15 AM, Erik Joelsson wrote: > > Looks good. > > /Erik > > On 2020-07-28 07:51, Igor Ignatyev wrote: >>> 1 files changed, 1 insertions(+), 1 deletions(-) >> Hi all, >> >> could you please review the one-liner which fixes the typo i

RFR 8250743: Switch to JCov build which supports byte code version 60

2020-07-28 Thread Alexander (Shura) Ilin
Hi, Can you please take a look on a quick fix to update JCov version: ——— $ hg diff diff -r 353f03fdf030 make/conf/jib-profiles.js --- a/make/conf/jib-profiles.js Tue Jul 28 15:31:10 2020 -0700 +++ b/make/conf/jib-profiles.js Tue Jul 28 22:19:22 2020 -0700