Hi all,
Could someone have a look at my updated webrev below?
Thanks
Galder
On Fri, Jul 10, 2020 at 6:48 PM Galder Zamarreno wrote:
> Hi again,
>
> I've got a new webrev for this:
> http://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8248158/02/webrev/
>
> It further expands `type -p` to replac
I think this looks ok. Have you tested it on Windows?
/Erik
On 2020-08-04 01:40, Galder Zamarreno wrote:
Hi all,
Could someone have a look at my updated webrev below?
Thanks
Galder
On Fri, Jul 10, 2020 at 6:48 PM Galder Zamarreno wrote:
Hi again,
I've got a new webrev for this:
http://
Hi Erik,
I've been in contact with Simon (cc) who has been testing the patch on
Windows and he said it all looked good.
@Simon Tooke , do you need to verify again?
Galder
On Tue, Aug 4, 2020 at 2:40 PM Erik Joelsson
wrote:
> I think this looks ok. Have you tested it on Windows?
>
> /Erik
>
>
Good observation David, the change in adlc is just fixing a symptom. The
difference to a regular macOS build is that technically, despite running on the
same machine, it's actually cross compiling due to Rosetta being the
--build=x86_64 system.
Being a cross-compile, we therefore hit this case:
That's a good find! You are correct in that we haven't cross compiled in
any direction involving Macosx before.
The preferred patch would be a bit more elaborate than that. Ideally we
need better control over the toolchain type of the BUILD_* compiler
settings. For now, I think just forcing cl
I ran this patch through our internal system (corresponds to the submit
repo), so it's working for us at least.
/Erik
On 2020-08-04 06:25, Galder Zamarreno wrote:
Hi Erik,
I've been in contact with Simon (cc) who has been testing the patch on
Windows and he said it all looked good.
@Simon
Thanks Bernhard. General cross-compilation improvement are a good thing.
Cheers,
David
-
On 5/08/2020 12:02 am, Bernhard Urban-Forster wrote:
Good observation David, the change in adlc is just fixing a symptom. The
difference to a regular macOS build is that technically, despite running on
