RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules

2020-08-06 Thread Galder Zamarreno
Hi, `bin/idea.sh` is not generating the right source folders for jdk.internal.vm.ci and jdk.internal.vm.compiler modules. These modules have different directory structures to the rest and so should be handled exceptionally so that the IDE has the right source folder definitions. The fix takes th

Re: RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules

2020-08-06 Thread Maurizio Cimadamore
The basic fix looks good, I'm wondering, however, if we would only want to enable sources which match the current configuration? E.g. not add the sources for aarch64 if building on linux? But if we build all these modules regardless, then it's ok to add them all. Maurizio On 06/08/2020 15:28,

Re: RFR: JDK-8251193 bin/idea.sh generating wrong source folders for JVMCI modules

2020-08-06 Thread Severin Gehwolf
Hi, On Thu, 2020-08-06 at 16:01 +0100, Maurizio Cimadamore wrote: > The basic fix looks good, I'm wondering, however, if we would only want > to enable sources which match the current configuration? E.g. not add > the sources for aarch64 if building on linux? But if we build all these > modules