RE: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread Baesken, Matthias
Hi Yasumasa , I'm more or less fine with the change . But still not fully convinced that removing the iteration is a good thing . http://cr.openjdk.java.net/~ysuenaga/JDK-8250598/webrev.01/src/hotspot/cpu/x86/vm_version_x86.cpp.frames.html 1827 for (base = 0x4000; base < 0x4001;

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread Yasumasa Suenaga
Hi Matthias, David, On 2020/08/12 21:12, David Holmes wrote: On 12/08/2020 8:51 pm, Baesken, Matthias wrote: Hi Yasumasa ,  I'm more or less fine with the change . But still not fully convinced  that removing  the iteration is a good thing .

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread David Holmes
On 12/08/2020 8:51 pm, Baesken, Matthias wrote: Hi Yasumasa , I'm more or less fine with the change . But still not fully convinced that removing the iteration is a good thing . http://cr.openjdk.java.net/~ysuenaga/JDK-8250598/webrev.01/src/hotspot/cpu/x86/vm_version_x86.cpp.frames.html

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread David Holmes
Hi Yasumasa, On 12/08/2020 10:56 pm, Yasumasa Suenaga wrote: Hi Matthias, David, On 2020/08/12 21:12, David Holmes wrote: On 12/08/2020 8:51 pm, Baesken, Matthias wrote: Hi Yasumasa ,  I'm more or less fine with the change . But still not fully convinced  that removing  the iteration is a

RE: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread Baesken, Matthias
>I understand that if the process runs on Xen on other hypervisor (e.g. KVM), >information for Xen would be set between 0x4100 and 0x4001. >Ok, I will not remove the loop in new webrev, and will add comment about it. Hi Yasumasa , thanks ! Regarding the WMI overhead , if you could get

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread David Holmes
On 13/08/2020 11:12 am, Yasumasa Suenaga wrote: Hi Matthias, David, I measured startup benchmarks with `Measure-Command {.\jdk\build\windows-x86_64-server-release\images\jdk\bin\java.exe --version}` on PowerShell. * PC: Ryzen 3 3300X, 16GB memory * OS: Windows 10 x64 (May 2020 Update) *

Re: PING: RFR: 8250598: Hyper-V is detected in spite of running on host OS

2020-08-12 Thread Yasumasa Suenaga
Hi Matthias, David, I measured startup benchmarks with `Measure-Command {.\jdk\build\windows-x86_64-server-release\images\jdk\bin\java.exe --version}` on PowerShell. * PC: Ryzen 3 3300X, 16GB memory * OS: Windows 10 x64 (May 2020 Update) * Java: jdk/jdk revision 60537 (Compiled by VS 2019