RFR: 8252233: Enable debug-image target to support producing a pure debug image package

2020-08-27 Thread Andrew Leonard
Hi, Please may I request a sponsor and review for this build enhancement to provide a pure debug "image", for those developers that want to accompany a straight jdk image with a debug-image when needed: https://bugs.openjdk.java.net/browse/JDK-8252233 webrev: http://cr.openjdk.java.net/~a

Re: RFR: 8252233: Enable debug-image target to support producing a pure debug image package

2020-08-27 Thread Severin Gehwolf
Hi Andrew, On Thu, 2020-08-27 at 16:55 +0100, Andrew Leonard wrote: > Hi, > Please may I request a sponsor and review for this build enhancement to > provide a pure debug "image", for those developers that want to accompany > a straight jdk image with a debug-image when needed: > https://bug

RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Philip Race
Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves the disabled compiler warnings in what is now quite a small fontmanager library. I've built windows, mac and linux in our build system and run our full battery of a

Re: RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Sergey Bylokhov
Hi, Phil. Probably we could enable WARNINGS_AS_ERRORS_xlc as well? I guess we will need a confirmation from the SAP gurus. On 27.08.2020 12:39, Philip Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves t

Re: RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Philip Race
I left that alone on purpose. I have no way of testing it and whereas for the 32 bit linux case I had an idea of what to fix, for xlc all I could find was it came in with https://bugs.openjdk.java.net/browse/JDK-8154087 and I've no idea what the problems were. SAP or IBM can look at it if they

Re: RFR: 8074844 : Resolve disabled warnings for libfontmanager

2020-08-27 Thread Erik Joelsson
Build change looks good. /Erik On 2020-08-27 12:39, Philip Race wrote: Bug : https://bugs.openjdk.java.net/browse/JDK-8074844 Webrev : http://cr.openjdk.java.net/~prr/8074844/index.html This resolves the disabled compiler warnings in what is now quite a small fontmanager library. I've built

Re: RFR: 8252233: Enable debug-image target to support producing a pure debug image package

2020-08-27 Thread Erik Joelsson
Hello Andrew, We certainly appreciate contributions, but this patch as it currently looks does not fit well with our current build system model. I'm however not against adding a target for your usecase. On a high level, just as Severin pointed out, the term "debug" is used for the type confi