Re: jdk14 build failed cause "The header is deprecated and will be removed."

2020-09-08 Thread Severin Gehwolf
On Wed, 2020-08-05 at 15:46 +0800, 451541695 wrote: > Hello,  Thanks for providing java for developers. >   I am trying to build jdk-14 to use, but failed to build. >   The error is following: > >    My environment: >       Linux: Ubuntu 20.04.1 LTS >       autoconfig: > >  I don't know what happ

RFR: 8252897: Minor .jcheck/conf update

2020-09-08 Thread Robin Westberg
The initial version of the Skara-formatted jcheck configuration file contained a small error, this change corrects it. Best regards, Robin - Commit messages: - Fix mistake in jcheck configuration file Changes: https://git.openjdk.java.net/jdk/pull/70/files Webrev: https://webrevs

Re: RFR: 8252897: Minor .jcheck/conf update

2020-09-08 Thread Erik Helin
On Tue, 8 Sep 2020 10:31:42 GMT, Robin Westberg wrote: > The initial version of the Skara-formatted jcheck configuration file > contained a small error, this change corrects it. > > Best regards, > Robin Looks good, thanks for fixing! - Marked as reviewed by ehelin (Reviewer). P

Re: RFR: 8252897: Minor .jcheck/conf update

2020-09-08 Thread Robin Westberg
On Tue, 8 Sep 2020 11:41:31 GMT, Erik Helin wrote: >> The initial version of the Skara-formatted jcheck configuration file >> contained a small error, this change corrects it. >> >> Best regards, >> Robin > > Looks good, thanks for fixing! Thanks for reviewing Erik! As this problem affects oth

Integrated: 8252897: Minor .jcheck/conf update

2020-09-08 Thread Robin Westberg
On Tue, 8 Sep 2020 10:31:42 GMT, Robin Westberg wrote: > The initial version of the Skara-formatted jcheck configuration file > contained a small error, this change corrects it. > > Best regards, > Robin This pull request has now been integrated. Changeset: bf5da0c7 Author:Robin Westberg

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port

2020-09-08 Thread Erik Joelsson
On Mon, 7 Sep 2020 11:23:28 GMT, Aleksei Voitylov wrote: > continuing the review thread from here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html > >> The download side of using JNI in these tests is that it complicates the >> setup a bit for those that run jt

Re: [8u] RFR: 8252395: [8u] --with-native-debug-symbols=external doesn't include debuginfo files for binaries

2020-09-08 Thread Andrew Hughes
On 13:44 Mon 31 Aug , Severin Gehwolf wrote: > Sorry, wrong webrev. Now corrected. > > On Mon, 2020-08-31 at 10:02 +0200, Severin Gehwolf wrote: > > Hi, > > > > Could I get a reivew of this 8u specific bug please? When configured > > --with-native-debug-symbols=external,zipped the resulting e

Re: [8u] RFR: 8252395: [8u] --with-native-debug-symbols=external doesn't include debuginfo files for binaries

2020-09-08 Thread Severin Gehwolf
Hi, On Tue, 2020-09-08 at 17:05 +0100, Andrew Hughes wrote: > On 13:44 Mon 31 Aug , Severin Gehwolf wrote: > > Sorry, wrong webrev. Now corrected. > > > > On Mon, 2020-08-31 at 10:02 +0200, Severin Gehwolf wrote: > > > Hi, > > > > > > Could I get a reivew of this 8u specific bug please? When

RFR: 8244778: Archive full module graph in CDS

2020-09-08 Thread Ioi Lam
This is the same patch as [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) published in [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/2020-August/041496.html). The rest of th

Re: [8u] RFR: 8252395: [8u] --with-native-debug-symbols=external doesn't include debuginfo files for binaries

2020-09-08 Thread Andrew Hughes
On 18:29 Tue 08 Sep , Severin Gehwolf wrote: snip... > > > Is any follow-on change for Windows necessary? > > I don't know as I don't have a way to test/develop it. It shouldn't > make anything worse on the Windows side, though. > Yes, I can see that and have approved this fix for 8u now.

Re: RFR: 8244778: Archive full module graph in CDS

2020-09-08 Thread Ioi Lam
On Tue, 8 Sep 2020 15:59:33 GMT, Ioi Lam wrote: > This is the same patch as > [8244778-archive-full-module-graph.v03](http://cr.openjdk.java.net/~iklam/jdk16/8244778-archive-full-module-graph.v03/) > published in > [hotspot-runtime-...@openjdk.java.net](https://mail.openjdk.java.net/pipermail/hot

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port

2020-09-08 Thread David Holmes
On Mon, 7 Sep 2020 11:23:28 GMT, Aleksei Voitylov wrote: > continuing the review thread from here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html > >> The download side of using JNI in these tests is that it complicates the >> setup a bit for those that run jt