Re: RFR: 8253206: Enforce whitespace checking for additional source files

2020-09-16 Thread Erik Joelsson
On Tue, 15 Sep 2020 22:18:09 GMT, Kevin Rushforth wrote: > This adds the following extensions to the list of source files that git > jcheck will check for whitespace errors: > > .cc, .hh, .m, .mm > > All files with the above extensions are now white-space clean after the fix > for > [JDK-824

Re: RFR: 8253207: enable problemlists jcheck's check

2020-09-16 Thread Erik Joelsson
On Wed, 16 Sep 2020 00:15:54 GMT, Igor Ignatyev wrote: > problemlists[[1]] check verifies that there are no problem-list entries w/ > the bug-id used in the commit message. > > [1]: https://github.com/openjdk/skara/pull/518 Marked as reviewed by erikj (Reviewer). - PR: https://gi

Re: RFR: 8253206: Enforce whitespace checking for additional source files

2020-09-16 Thread Jayathirth D V
On Tue, 15 Sep 2020 22:18:09 GMT, Kevin Rushforth wrote: > This adds the following extensions to the list of source files that git > jcheck will check for whitespace errors: > > .cc, .hh, .m, .mm > > All files with the above extensions are now white-space clean after the fix > for > [JDK-824

Integrated: 8253206: Enforce whitespace checking for additional source files

2020-09-16 Thread Kevin Rushforth
On Tue, 15 Sep 2020 22:18:09 GMT, Kevin Rushforth wrote: > This adds the following extensions to the list of source files that git > jcheck will check for whitespace errors: > > .cc, .hh, .m, .mm > > All files with the above extensions are now white-space clean after the fix > for > [JDK-824

RFR: 8253253: Binutils tar ball extension update to gz

2020-09-16 Thread Junyuan Zheng
Our infra team found this error when building DevKit with GCC 4.9.2. The binutils version is 2.25, and an *.xz doesn't exist on https://ftp.gnu.org/pub/gnu/binutils. Hence, we would like to submit a PR to update *.xz to *.gz. We have confirmed that *.gz exists for all binutil version.

Re: RFR: 8253207: enable problemlists jcheck's check

2020-09-16 Thread Igor Ignatyev
On Wed, 16 Sep 2020 13:08:17 GMT, Erik Joelsson wrote: >> problemlists[[1]] check verifies that there are no problem-list entries w/ >> the bug-id used in the commit message. >> >> [1]: https://github.com/openjdk/skara/pull/518 > > Marked as reviewed by erikj (Reviewer). thanks for your review

Re: RFR: 8253253: Binutils tar ball extension update to gz

2020-09-16 Thread Erik Joelsson
On Tue, 15 Sep 2020 04:54:04 GMT, Junyuan Zheng wrote: > Our infra team found this error when building DevKit with GCC 4.9.2. The > binutils version is 2.25, and an *.xz doesn't > exist on https://ftp.gnu.org/pub/gnu/binutils. Hence, we would like to > submit a PR to update *.xz to *.gz. > We

Integrated: 8253207: enable problemlists jcheck's check

2020-09-16 Thread Igor Ignatyev
On Wed, 16 Sep 2020 00:15:54 GMT, Igor Ignatyev wrote: > problemlists[[1]] check verifies that there are no problem-list entries w/ > the bug-id used in the commit message. > > [1]: https://github.com/openjdk/skara/pull/518 This pull request has now been integrated. Changeset: d38c97dd Author

Re: RFR: 8253253: Binutils tar ball extension update to gz

2020-09-16 Thread Junyuan Zheng
On Wed, 16 Sep 2020 17:20:18 GMT, Erik Joelsson wrote: >> Our infra team found this error when building DevKit with GCC 4.9.2. The >> binutils version is 2.25, and an *.xz doesn't >> exist on https://ftp.gnu.org/pub/gnu/binutils. Hence, we would like to >> submit a PR to update *.xz to *.gz. >

Re: RFR: 8253253: Binutils tar ball extension update to gz

2020-09-16 Thread Erik Joelsson
On Wed, 16 Sep 2020 17:32:22 GMT, Junyuan Zheng wrote: >> Marked as reviewed by erikj (Reviewer). > > We only use the GCC 4.9.2 for jdk8u. The openjdk/jdk repository's devkit > contains all devkits that support older jdk. > So we can just use this file to build all the devkits instead of pullin

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive

2020-09-16 Thread Ioi Lam
On Tue, 15 Sep 2020 18:57:55 GMT, Yumin Qi wrote: > This patch is reorganized after 8252725, which is separated from this patch > to refactor jlink glugin code. The previous > webrev with hg can be found at: > http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 > integrated,

Re: RFR: 8247536: Support for pre-generated java.lang.invoke classes in CDS static archive

2020-09-16 Thread Yumin Qi
On Wed, 16 Sep 2020 19:05:56 GMT, Ioi Lam wrote: >> This patch is reorganized after 8252725, which is separated from this patch >> to refactor jlink glugin code. The previous >> webrev with hg can be found at: >> http://cr.openjdk.java.net/~minqi/2020/8247536/webrev-05. With 8252725 >> integra