Re: RFR: 8245194: Unix domain socket channel implementation [v12]

2020-10-02 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8245194: Unix domain socket channel implementation [v13]

2020-10-02 Thread Michael McMahon
> Continuing this review as a PR on github with the comments below > incorporated. I expect there will be a few more > iterations before integrating. > On 06/09/2020 19:47, Alan Bateman wrote: >> On 26/08/2020 15:24, Michael McMahon wrote: >>> >>> As I mentioned the other day, I wasn't able to use

Re: RFR: 8253757: Add LLVM-based backend for hsdis

2020-10-02 Thread Magnus Ihse Bursie
On Wed, 30 Sep 2020 00:55:23 GMT, Ludovic Henry wrote: >> When bringing up Hotspot onto new platforms, it is not always possible to >> compile hsdis because gcc is not yet >> available. For example, for Windows-AArch64 and macOS-AArch64. >> For some such platforms, it is possible to use LLVM as

Re: RFR: 8245194: Unix domain socket channel implementation [v13]

2020-10-02 Thread Erik Joelsson
On Fri, 2 Oct 2020 11:28:49 GMT, Michael McMahon wrote: >> Continuing this review as a PR on github with the comments below >> incorporated. I expect there will be a few more >> iterations before integrating. >> On 06/09/2020 19:47, Alan Bateman wrote: >>> On 26/08/2020 15:24, Michael McMahon wr

Re: RFR: 8253865: Pre-submit testing using GitHub Actions does not detect failures reliably

2020-10-02 Thread Erik Joelsson
On Wed, 30 Sep 2020 16:58:25 GMT, Robin Westberg wrote: > The pre-submit test definitions utilizing GitHub Actions can sometimes report > success even when there are failing > tests. The failure detection depended on make returning a non-zero exit code > on failures, which doesn't seem to work.

Integrated: 8253865: Pre-submit testing using GitHub Actions does not detect failures reliably

2020-10-02 Thread Robin Westberg
On Wed, 30 Sep 2020 16:58:25 GMT, Robin Westberg wrote: > The pre-submit test definitions utilizing GitHub Actions can sometimes report > success even when there are failing > tests. The failure detection depended on make returning a non-zero exit code > on failures, which doesn't seem to work.

Re: RFR: 8245194: Unix domain socket channel implementation [v13]

2020-10-02 Thread Michael McMahon
On Fri, 2 Oct 2020 12:58:02 GMT, Erik Joelsson wrote: >> Michael McMahon has updated the pull request incrementally with one >> additional commit since the last revision: >> >> unixdomainchannels: error in the last commit in >> make/modules/java.base/Copy.gmk > > make/modules/java.base/Copy.

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v3]

2020-10-02 Thread Aleksei Voitylov
> continuing the review thread from here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html > >> The download side of using JNI in these tests is that it complicates the >> setup a bit for those that run jtreg directly and/or just build the JDK >> and not the test

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v4]

2020-10-02 Thread Aleksei Voitylov
> continuing the review thread from here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html > >> The download side of using JNI in these tests is that it complicates the >> setup a bit for those that run jtreg directly and/or just build the JDK >> and not the test

Re: RFR: JDK-8247589: Implementation of Alpine Linux/x64 Port [v5]

2020-10-02 Thread Aleksei Voitylov
> continuing the review thread from here > https://mail.openjdk.java.net/pipermail/core-libs-dev/2020-September/068546.html > >> The download side of using JNI in these tests is that it complicates the >> setup a bit for those that run jtreg directly and/or just build the JDK >> and not the test

Re: RFR: 8252998: ModuleWrapper.gmk doesn't consult include path

2020-10-02 Thread Adam Farley
On Mon, 21 Sep 2020 16:45:35 GMT, Severin Gehwolf wrote: >> Looks good. > > @adamfarley Please see > https://github.com/openjdk/jdk/pull/250#issuecomment-694845694 for getting > this integrated. For > non-committers it's `/integrate` and then `/sponsor` by somebody with commit > rights. Apolo

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-10-02 Thread Chris Hegarty
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in th

Re: RFR: 8223347: Integration of Vector API (Incubator)

2020-10-02 Thread Vladimir Kozlov
On Fri, 25 Sep 2020 20:14:29 GMT, Paul Sandoz wrote: > This pull request is for integration of the Vector API. It was previously > reviewed under conditions when mercurial was > used for the source code control system. Review threads can be found here > (searching for issue number 8223347 in th

Re: RFR: 8248238: Implementation: JEP 388: Windows AArch64 Support [v12]

2020-10-02 Thread Monica Beckwith
On Wed, 30 Sep 2020 00:40:29 GMT, David Holmes wrote: >> Monica Beckwith has updated the pull request incrementally with one >> additional commit since the last revision: >> >> change string representation for r18 to "r18_tls" on every platform > > Marked as reviewed by dholmes (Reviewer). >