RFR: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution

2020-10-22 Thread Aleksey Shipilev
Bisection shows it started to happen after [JDK-8253660](https://bugs.openjdk.java.net/browse/JDK-8253660). I believe `toString()` there is not very resilient in the face of `null` causes. Example output: $ make run-test TEST=compiler/aot STDERR: java.lang.NullPointerException: Cannot invoke "j

Re: RFR: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution

2020-10-22 Thread Erik Joelsson
On Thu, 22 Oct 2020 08:55:09 GMT, Aleksey Shipilev wrote: > Bisection shows it started to happen after > [JDK-8253660](https://bugs.openjdk.java.net/browse/JDK-8253660). I believe > `toString()` there is not very resilient in the face of `null` causes. > > Example output: > $ make run-test TES

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-22 Thread Maurizio Cimadamore
On Tue, 20 Oct 2020 21:31:17 GMT, Paul Sandoz wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into 8254231_linker >> - Fix incorrect capitalization in one c

Re: RFR: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution

2020-10-22 Thread Aleksey Shipilev
On Thu, 22 Oct 2020 12:53:23 GMT, Erik Joelsson wrote: >> Bisection shows it started to happen after >> [JDK-8253660](https://bugs.openjdk.java.net/browse/JDK-8253660). I believe >> `toString()` there is not very resilient in the face of `null` causes. >> >> Example output: >> $ make run-test

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v9]

2020-10-22 Thread Maurizio Cimadamore
On Wed, 21 Oct 2020 16:23:16 GMT, Paul Sandoz wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 27 commits: >> >> - Merge branch 'master' into 8254231_linker >> - Don't use JNI when generating native

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-22 Thread Jorn Vernee
On Tue, 20 Oct 2020 21:08:26 GMT, Paul Sandoz wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into 8254231_linker >> - Fix incorrect capitalization in one c

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-22 Thread Jorn Vernee
On Tue, 20 Oct 2020 21:53:55 GMT, Paul Sandoz wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into 8254231_linker >> - Fix incorrect capitalization in one c

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-22 Thread Paul Sandoz
On Thu, 22 Oct 2020 13:30:13 GMT, Maurizio Cimadamore wrote: >> src/jdk.incubator.foreign/share/classes/jdk/incubator/foreign/CLinker.java >> line 126: >> >>> 124: * >>> 125: * @param symbol downcall symbol. >>> 126: * @param type the method type. >> >> s/method type/carr

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-22 Thread Paul Sandoz
On Thu, 22 Oct 2020 14:31:12 GMT, Jorn Vernee wrote: >> src/java.base/share/classes/java/lang/invoke/NativeMethodHandle.java line 36: >> >>> 34: import static java.lang.invoke.MethodHandleStatics.newInternalError; >>> 35: >>> 36: /** TODO */ >> >> Is the TODO to make this class public later an

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v9]

2020-10-22 Thread Paul Sandoz
On Thu, 22 Oct 2020 14:26:37 GMT, Maurizio Cimadamore wrote: >> src/jdk.incubator.foreign/share/classes/jdk/internal/foreign/AbstractNativeScope.java >> line 120: >> >>> 118: } >>> 119: } >>> 120: throw new AssertionError("Cannot get here!"); >> >> This

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v10]

2020-10-22 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-22 Thread Maurizio Cimadamore
On Wed, 21 Oct 2020 19:05:42 GMT, Paul Sandoz wrote: >> Maurizio Cimadamore has updated the pull request with a new target base due >> to a merge or a rebase. The pull request now contains 25 commits: >> >> - Merge branch 'master' into 8254231_linker >> - Fix incorrect capitalization in one c

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-22 Thread Maurizio Cimadamore
On Thu, 22 Oct 2020 15:46:33 GMT, Paul Sandoz wrote: >> IIRC this was added to silence a javac linter warning. Something should be >> added here. There is/was no plan to make this class public though. > > It's odd the lint warning is triggering on a package private class and > private methods.

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v9]

2020-10-22 Thread Maurizio Cimadamore
On Wed, 21 Oct 2020 17:42:53 GMT, Paul Sandoz wrote: > Some design considerations, to consider later maybe. > > The IR representation could be simplified to use record classes (which should > be exiting preview in 16), implementing a Binding interface. The interpreter > and specializer (compil

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v7]

2020-10-22 Thread Jorn Vernee
On Thu, 22 Oct 2020 16:31:00 GMT, Maurizio Cimadamore wrote: >> Some of this is familiar to me from reviews in the `panama-foreign` >> repository, but less so than the memory API. I focused on the Java code, and >> ignored changes that are common with the memory API PR. >> >> If it helps in c

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v11]

2020-10-22 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8254231: Implementation of Foreign Linker API (Incubator) [v12]

2020-10-22 Thread Maurizio Cimadamore
> This patch contains the changes associated with the first incubation round of > the foreign linker access API incubation > (see JEP 389 [1]). This work is meant to sit on top of the foreign memory > access support (see JEP 393 [2] and associated pull request [3]). > > The main goal of this API

Re: RFR: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution

2020-10-22 Thread Christoph Langer
On Thu, 22 Oct 2020 08:55:09 GMT, Aleksey Shipilev wrote: > Bisection shows it started to happen after > [JDK-8253660](https://bugs.openjdk.java.net/browse/JDK-8253660). I believe > `toString()` there is not very resilient in the face of `null` causes. > > Example output: > $ make run-test TES

Integrated: 8255225: compiler/aot tests fail on Windows with NPE during artifact resolution

2020-10-22 Thread Aleksey Shipilev
On Thu, 22 Oct 2020 08:55:09 GMT, Aleksey Shipilev wrote: > Bisection shows it started to happen after > [JDK-8253660](https://bugs.openjdk.java.net/browse/JDK-8253660). I believe > `toString()` there is not very resilient in the face of `null` causes. > > Example output: > $ make run-test TES