RFR: 8255352: Archive important test outputs in submit workflow

2020-10-24 Thread Aleksey Shipilev
Currently, we are only archiving `build/*/test-results`. But hs_errs, replays, and test outputs are actually in `build/*/test-support`! Which means once any test fails, we only have the summary of the run, not the bits that would actually help to diagnose the problem. Archiving the entire test

RFR: 8255373: Submit workflow artifact name is always "test-results_.zip"

2020-10-24 Thread Aleksey Shipilev
The output for the `prerequisites` step is `bundle_id: ${{ steps.check_bundle_id.outputs.bundle_id }}`, but there is no `check_bundle_id` step name to properly reference. Then `artifacts` should actually need `prerequisites` to access `needs.prerequisites.outputs.bundle_id`. See the final artif

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-24 Thread Kim Barrett
On Fri, 16 Oct 2020 19:22:16 GMT, Mandy Chung wrote: >> I just want to note that if you have a `Reference ref` at hand, >> you can not just do: >> Referemce r = (Reference) ref; >> ...since those generic types are not related. You have to do something like: >> >> @SuppressWarnings({"unchecked",

Re: RFR: 8188055: (ref) Add Reference::refersTo predicate [v6]

2020-10-24 Thread Peter Levart
On Fri, 16 Oct 2020 19:22:16 GMT, Mandy Chung wrote: >> I just want to note that if you have a `Reference ref` at hand, >> you can not just do: >> Referemce r = (Reference) ref; >> ...since those generic types are not related. You have to do something like: >> >> @SuppressWarnings({"unchecked",