Re: RFR: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow [v5]

2020-12-09 Thread Magnus Ihse Bursie
On Wed, 9 Dec 2020 07:22:51 GMT, Bernhard Urban-Forster wrote: >> This adds the cross-compiled build only, as no Windows+Arm64 machines are >> available on GitHub Action that we could use to run the tests. >> >> Due to cross-compilation a build JDK is required. Initially I added EA >> builds

Integrated: 8256657: Add cross-compiled build for Windows+Arm64 to submit workflow

2020-12-09 Thread Bernhard Urban-Forster
On Mon, 23 Nov 2020 09:35:40 GMT, Bernhard Urban-Forster wrote: > This adds the cross-compiled build only, as no Windows+Arm64 machines are > available on GitHub Action that we could use to run the tests. > > Due to cross-compilation a build JDK is required. Initially I added EA builds > to b

Re: RFR: 8257620: Do not use objc_msgSend_stret to get macOS version

2020-12-09 Thread Magnus Ihse Bursie
On Wed, 2 Dec 2020 17:34:00 GMT, Anton Kozlov wrote: > Please review a small change that replaces use of objc_msgSend_stret in macOS > platform code with pure ObjC code. It's also a prerequisite for macOS/AArch64 > support, where objc_msgSend_stret is not available. >From a build PoV this soun

Re: RFR: JDK-8250768: javac should be adapted to changes in JEP 12 [v12]

2020-12-09 Thread Magnus Ihse Bursie
On Tue, 8 Dec 2020 19:35:03 GMT, Jan Lahoda wrote: >> This is an update to javac and javadoc, to introduce support for Preview >> APIs, and generally improve javac and javadoc behavior to more closely >> adhere to JEP 12. >> >> The notable changes are: >> >> * adding support for Preview APIs

Re: RFR: 8257450: Start of release updates for JDK 17 [v6]

2020-12-09 Thread Magnus Ihse Bursie
On Tue, 8 Dec 2020 23:23:55 GMT, Joe Darcy wrote: >> Start of JDK 17 updates. > > Joe Darcy has updated the pull request with a new target base due to a merge > or a rebase. The incremental webrev excludes the unrelated changes brought in > by the merge/rebase. The pull request contains 14 addi

RFR: 8257973: UTIL_LOOKUP_PROGS should only find executable files

2020-12-09 Thread Magnus Ihse Bursie
It turns out that UTIL_LOOKUP_PROGS does not verify that when it find a file in the PATH that matches the given tool name, it accept it straight away. Even if the file is a directory, or is not executable. - Commit messages: - 8257973: UTIL_LOOKUP_PROGS should only find executable

Re: RFR: 8257620: Do not use objc_msgSend_stret to get macOS version

2020-12-09 Thread Roger Riggs
On Wed, 2 Dec 2020 17:34:00 GMT, Anton Kozlov wrote: > Please review a small change that replaces use of objc_msgSend_stret in macOS > platform code with pure ObjC code. It's also a prerequisite for macOS/AArch64 > support, where objc_msgSend_stret is not available. Looks ok to me. But it woul

Re: RFR: 8257973: UTIL_LOOKUP_PROGS should only find executable files

2020-12-09 Thread Erik Joelsson
On Wed, 9 Dec 2020 14:08:32 GMT, Magnus Ihse Bursie wrote: > It turns out that UTIL_LOOKUP_PROGS does not verify that when it find a file > in the PATH that matches the given tool name, it accept it straight away. > Even if the file is a directory, or is not executable. Marked as reviewed by e

Re: RFR: JDK-8256950: Add record attribute support to symbol generator CreateSymbols [v6]

2020-12-09 Thread Jan Lahoda
> Adding support for record classes in the historical data for ct.sym. This > includes a few changes not strictly needed for the change: > -updating and moving tests into test/langtools, so that it is easier to run > them. > -fixing Record attribute reading in javac's ClassReader (used for tests,

Integrated: JDK-8256950: Add record attribute support to symbol generator CreateSymbols

2020-12-09 Thread Jan Lahoda
On Fri, 27 Nov 2020 13:21:15 GMT, Jan Lahoda wrote: > Adding support for record classes in the historical data for ct.sym. This > includes a few changes not strictly needed for the change: > -updating and moving tests into test/langtools, so that it is easier to run > them. > -fixing Record att

Integrated: 8257973: UTIL_LOOKUP_PROGS should only find executable files

2020-12-09 Thread Magnus Ihse Bursie
On Wed, 9 Dec 2020 14:08:32 GMT, Magnus Ihse Bursie wrote: > It turns out that UTIL_LOOKUP_PROGS does not verify that when it find a file > in the PATH that matches the given tool name, it accept it straight away. > Even if the file is a directory, or is not executable. This pull request has n

Re: RFR: 8251854: [macosx] Java forces the use of discrete GPU

2020-12-09 Thread Victor Dyakov
On Tue, 17 Nov 2020 18:55:51 GMT, Sergey Bylokhov wrote: >> I ran a 3D lighting test that is designed to be a GPU stress test. It's a >> worst case, to be sure, but it take 10 times as long to render with the >> integrated GPU as it does with the discrete GPU: >> >> **attenuation.LightingSampl

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default)

2020-12-09 Thread Mukilesh Sethu
On Fri, 4 Dec 2020 15:25:23 GMT, Markus Grönlund wrote: > Greetings, > > please help review this enhancement to let JFR sample object allocations by > default. > > A description is provided in the JIRA issue. > > Thanks > Markus This is great! It would be awesome to have this capability. On

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) [v4]

2020-12-09 Thread Markus Grönlund
> Greetings, > > please help review this enhancement to let JFR sample object allocations by > default. > > A description is provided in the JIRA issue. > > Thanks > Markus Markus Grönlund has updated the pull request incrementally with 12 additional commits since the last revision: - initi

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) [v4]

2020-12-09 Thread Erik Gahlin
On Wed, 9 Dec 2020 20:58:48 GMT, Markus Grönlund wrote: >> Greetings, >> >> please help review this enhancement to let JFR sample object allocations by >> default. >> >> A description is provided in the JIRA issue. >> >> Thanks >> Markus > > Markus Grönlund has updated the pull request increm

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default) [v4]

2020-12-09 Thread Markus Grönlund
On Tue, 8 Dec 2020 16:31:37 GMT, Erik Gahlin wrote: >> Markus Grönlund has updated the pull request incrementally with 12 >> additional commits since the last revision: >> >> - initialization check >> - thread locals and detach and reattach >> - Tighter ThrottleUnit >> - JFC control element

Re: RFR: 8257602: Introduce JFR Event Throttling and new jdk.ObjectAllocationSample event (enabled by default)

2020-12-09 Thread Markus Grönlund
On Mon, 7 Dec 2020 22:37:20 GMT, Mukilesh Sethu wrote: >> Greetings, >> >> please help review this enhancement to let JFR sample object allocations by >> default. >> >> A description is provided in the JIRA issue. >> >> Thanks >> Markus > > This is great! It would be awesome to have this cap

Re: RFR: 8257733: Move module-specific data from make to respective module [v2]

2020-12-09 Thread Weijun Wang
On Mon, 7 Dec 2020 14:27:45 GMT, Magnus Ihse Bursie wrote: >> A lot (but not all) of the data in make/data is tied to a specific module. >> For instance, the publicsuffixlist is used by java.base, and fontconfig by >> java.desktop. (A few directories, like mainmanifest, is *actually* used by >

Re: RFR: 8257450: Start of release updates for JDK 17 [v7]

2020-12-09 Thread Joe Darcy
> Start of JDK 17 updates. Joe Darcy has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 17 additional commits since the last revision: - Merge branch 'm