Re: RFR: 8257928: Test image build failure with clang-10 due to -Wmisleading-indentation

2020-12-22 Thread Alex Menkov
On Wed, 9 Dec 2020 07:11:53 GMT, Hao Sun wrote: > Flag '-Wmisleading-indentation' was introduced since clang-10 [1] and > gcc-6 [2]. Putting the code with proper indentations would suppress this > warning. > > The main reason why test image build with gcc succeeds is that, clang > and gcc might

Re: RFR: 8257928: Test image build failure with clang-10 due to -Wmisleading-indentation

2020-12-22 Thread Chris Plummer
On Wed, 9 Dec 2020 07:11:53 GMT, Hao Sun wrote: > Flag '-Wmisleading-indentation' was introduced since clang-10 [1] and > gcc-6 [2]. Putting the code with proper indentations would suppress this > warning. > > The main reason why test image build with gcc succeeds is that, clang > and gcc might

Integrated: 8257928: Test image build failure with clang-10 due to -Wmisleading-indentation

2020-12-22 Thread Hao Sun
On Wed, 9 Dec 2020 07:11:53 GMT, Hao Sun wrote: > Flag '-Wmisleading-indentation' was introduced since clang-10 [1] and > gcc-6 [2]. Putting the code with proper indentations would suppress this > warning. > > The main reason why test image build with gcc succeeds is that, clang > and gcc might

Re: RFR: 8247957: remove doclint support for HTML 4 [v5]

2020-12-22 Thread Jonathan Gibbons
On Fri, 18 Dec 2020 02:34:16 GMT, Yoshiki Sato wrote: >> HTML4 is no longer supported in javadoc. >> >> doclint needs to drop HTML4 support as well. >> The changes consist of: >> * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references. >> * Sorting out supported tags and attribute

Re: RFR: 8247957: remove doclint support for HTML 4 [v4]

2020-12-22 Thread Jonathan Gibbons
On Fri, 18 Dec 2020 01:34:15 GMT, Yoshiki Sato wrote: >> HTML4 is no longer supported in javadoc. >> >> doclint needs to drop HTML4 support as well. >> The changes consist of: >> * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references. >> * Sorting out supported tags and attribute

RFR: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy and -Wimplicit-int-float-conversion

2020-12-22 Thread Hao Sun
1. '-Wdeprecated-copy' As specified in C++11 [1], "the generation of the implicitly-defined copy constructor is deprecated if T has a user-defined destructor or user-defined copy assignment operator". The rationale behind is the well-known Rule of Three [2]. Introduced since gcc-9 [3] and clang-10

Re: RFR: 8247957: remove doclint support for HTML 4 [v5]

2020-12-22 Thread Yoshiki Sato
On Wed, 23 Dec 2020 01:32:29 GMT, Jonathan Gibbons wrote: >> Yoshiki Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 5th: 8258460: Remove --doclint-format option from javac > > Looks good. > I'll pull down a copy, for review in an I

Re: RFR: 8247957: remove doclint support for HTML 4 [v4]

2020-12-22 Thread Yoshiki Sato
On Wed, 23 Dec 2020 01:27:30 GMT, Jonathan Gibbons wrote: >> Yoshiki Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 5th: 8257204 and 8256313 >> 8257204: Remove usage of -Xhtmlversion option from javac >> 8256313: JavaCompilatio

Re: RFR: 8247957: remove doclint support for HTML 4 [v5]

2020-12-22 Thread Jonathan Gibbons
On Fri, 18 Dec 2020 02:34:16 GMT, Yoshiki Sato wrote: >> HTML4 is no longer supported in javadoc. >> >> doclint needs to drop HTML4 support as well. >> The changes consist of: >> * Removing jdk.javadoc.internal.doclint.HtmlVersion and its references. >> * Sorting out supported tags and attribute

Re: RFR: 8247957: remove doclint support for HTML 4 [v5]

2020-12-22 Thread Yoshiki Sato
On Wed, 23 Dec 2020 05:01:44 GMT, Jonathan Gibbons wrote: >> Yoshiki Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 5th: 8258460: Remove --doclint-format option from javac > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/docl

RFR: 8258856: VM build without C1/C2 fails after JDK-8243205

2020-12-22 Thread Hao Sun
The declaration sites for JVM flags were changed by JDK-8243205 and the subsequent JDK-8258074. As a result, undeclared identifier errors occurred while building VM without compiler1 or compiler2 feature. Making the corresponding header files included would fix it. Note that we have tested locall

Re: RFR: 8258856: VM build without C1/C2 fails after JDK-8243205

2020-12-22 Thread Jie Fu
On Wed, 23 Dec 2020 05:48:10 GMT, Hao Sun wrote: > The declaration sites for JVM flags were changed by JDK-8243205 and the > subsequent JDK-8258074. As a result, undeclared identifier errors > occurred while building VM without compiler1 or compiler2 feature. > > Making the corresponding header

Re: RFR: 8247957: remove doclint support for HTML 4 [v5]

2020-12-22 Thread Yoshiki Sato
On Wed, 23 Dec 2020 05:08:04 GMT, Jonathan Gibbons wrote: >> Yoshiki Sato has updated the pull request incrementally with one additional >> commit since the last revision: >> >> 5th: 8258460: Remove --doclint-format option from javac > > src/jdk.javadoc/share/classes/jdk/javadoc/internal/docl

Re: RFR: 8258856: VM build without C1/C2 fails after JDK-8243205

2020-12-22 Thread Hao Sun
On Wed, 23 Dec 2020 06:29:45 GMT, Jie Fu wrote: >> The declaration sites for JVM flags were changed by JDK-8243205 and the >> subsequent JDK-8258074. As a result, undeclared identifier errors >> occurred while building VM without compiler1 or compiler2 feature. >> >> Making the corresponding hea

Re: RFR: 8258856: VM build without C1/C2 fails after JDK-8243205

2020-12-22 Thread Hao Sun
On Wed, 23 Dec 2020 06:31:08 GMT, Jie Fu wrote: >> The declaration sites for JVM flags were changed by JDK-8243205 and the >> subsequent JDK-8258074. As a result, undeclared identifier errors >> occurred while building VM without compiler1 or compiler2 feature. >> >> Making the corresponding hea

Re: RFR: 8247957: remove doclint support for HTML 4 [v5]

2020-12-22 Thread Yoshiki Sato
On Wed, 23 Dec 2020 05:38:36 GMT, Yoshiki Sato wrote: >> src/jdk.javadoc/share/classes/jdk/javadoc/internal/doclint/Checker.java line >> 736: >> >>> 734: >>> 735: // https://html.spec.whatwg.org/#the-id-attribute >>> 736: private static final Pattern validId = Pattern.compile("[^\s]+")