How to rerun failed tests?

2021-02-22 Thread Reingruber, Richard
Hi, I'd like to rerun failed tests from a previous test run like this: make test TEST=jtreg:test/hotspot/jtreg:tier1 JTREG_STATUS=fail,error This is not working because the workdir from the previous run is deleted. Is there a way to rerun failed tests that I might have missed? If there isn't,

Re: RFR: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

2021-02-22 Thread Adam Farley
On Fri, 22 Jan 2021 15:13:45 GMT, Magnus Ihse Bursie wrote: >> Ensure make files look on the include path or in PHASE_MAKEDIRS for >> customizations. >> >> Change also adds a tidy-up that improves readability. > > Marked as reviewed by ihse (Reviewer). We have 2 positive reviews, and all we nee

Re: RFR: JDK-8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

2021-02-22 Thread Adam Farley
Hi All, Sponsor requested for a simple fix (reviews already complete). This change restores the ability of these makefiles to include customizations. No sign this ability was removed deliberately, so I think it was just a mistake. Also includes a small readability improvement. Bug: https://bug

Re: RFR: JDK-8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

2021-02-22 Thread Magnus Ihse Bursie
You need to give the "/integrate" PR command. I can sponsor it afterwards. /Magnus On 2021-02-22 11:19, Adam Farley wrote: Hi All, Sponsor requested for a simple fix (reviews already complete). This change restores the ability of these makefiles to include customizations. No sign this abilit

Re: How to rerun failed tests?

2021-02-22 Thread erik . joelsson
Hello Richard, No, there isn't a way to do that AFAIK, but it does seem like a good idea. The JTREG_STATUS variable isn't currently meant to be a public API from RunTests.gmk, but your patch does demonstrate how this could be achieved. I've filed https://bugs.openjdk.java.net/browse/JDK-826213

Re: RFR: JDK-8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

2021-02-22 Thread Adam Farley
Thanks Magnus. :) Command given. Best Regards Adam Farley Software Developer Red Hat On Mon, Feb 22, 2021 at 4:42 PM Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > You need to give the "/integrate" PR command. I can sponsor it afterwards. > > /Magnus > > On 2021-02-22 11:19, Ada

Integrated: 8259942: Enable customizations in CompileJavaModules.gmk and Main.gmk

2021-02-22 Thread Adam Farley
On Mon, 18 Jan 2021 18:27:14 GMT, Adam Farley wrote: > Ensure make files look on the include path or in PHASE_MAKEDIRS for > customizations. > > Change also adds a tidy-up that improves readability. This pull request has now been integrated. Changeset: cf0019d9 Author:Adam Farley Committe

RE: How to rerun failed tests?

2021-02-22 Thread Reingruber, Richard
Hi Erik, > No, there isn't a way to do that AFAIK, but it does seem like a good > idea. The JTREG_STATUS variable isn't currently meant to be a public API > from RunTests.gmk, but your patch does demonstrate how this could be > achieved. I've filed https://bugs.openjdk.java.net/browse/JDK-82621

Re: RFR: 8259886 : Improve SSL session cache performance and scalability [v2]

2021-02-22 Thread djelinski
On Tue, 16 Feb 2021 19:38:50 GMT, djelinski wrote: >>> I may think it differently. It may be hard to know the future frequency of >>> an cached item based on the past behaviors. For the above case, I'm not >>> sure that K=3 is used less frequently than K=1. Maybe, next few seconds, >>> K=1 co

Re: RFR: 8259886 : Improve SSL session cache performance and scalability [v2]

2021-02-22 Thread Xue-Lei Andrew Fan
On Mon, 22 Feb 2021 20:36:53 GMT, djelinski wrote: > Actually there's a much easier solution to reduce the number of slow `put()`s > without making any behavioral changes. > The cache object could store the earliest expire time, and then exit > `expungeExpiredEntries()` early when current time