Re: RFR: 8260931: Implement JEP 382: New macOS Rendering Pipeline [v11]

2021-03-08 Thread Ajit Ghaisas
> **Description :** > This is the implementation of [JEP 382 : New macOS Rendering > Pipeline](https://bugs.openjdk.java.net/browse/JDK-8238361) > It implements a Java 2D internal rendering pipeline for macOS using the Apple > Metal API. > The entire work on this was done under [OpenJDK Project -

Integrated: 8257913: Add more known library locations to simplify Linux cross-compilation

2021-03-08 Thread Aleksey Shipilev
On Thu, 4 Mar 2021 18:58:03 GMT, Aleksey Shipilev wrote: > Current cross-compilation configurations require adding the whole lot of > configure options to make it find the dependencies: freetype and X11 libs are > the only problematic dependencies. We should be able to specify just the > `--wi

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

2021-03-08 Thread Claes Redestad
On Fri, 5 Mar 2021 17:25:02 GMT, Erik Joelsson wrote: >> Good! >> Eric > > Should also updated jib-profiles.js Oracle builds get the new version. Uploaded and verified jib picks up the new version. - PR: https://git.openjdk.java.net/jdk/pull/2848

Re: RFR: JDK-8251210: Link JDK api docs to other versions

2021-03-08 Thread Erik Joelsson
On Sat, 6 Mar 2021 02:21:00 GMT, Jonathan Gibbons wrote: > Please review a small change to Docs.gmk, such that the short version string > in the upper right corner of the main API docs bundle is linked to a page > that links to other versions of the documentation. While it is not so useful >

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

2021-03-08 Thread Erik Joelsson
On Fri, 5 Mar 2021 19:25:26 GMT, Claes Redestad wrote: >> Currently at 1.26, so there are a few good improvements and a few bug fixes >> - notably resolving a build reproducibility issue. > > Claes Redestad has updated the pull request incrementally with one additional > commit since the last r

Re: RFR: 8263097: Update JMH devkit to 1.28 [v2]

2021-03-08 Thread Claes Redestad
On Mon, 8 Mar 2021 14:18:27 GMT, Erik Joelsson wrote: >> Claes Redestad has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Keep jib-profiles in sync > > Marked as reviewed by erikj (Reviewer). Thank you for reviewing, Eric and Erik! -

Integrated: 8263097: Update JMH devkit to 1.28

2021-03-08 Thread Claes Redestad
On Fri, 5 Mar 2021 16:04:49 GMT, Claes Redestad wrote: > Currently at 1.26, so there are a few good improvements and a few bug fixes - > notably resolving a build reproducibility issue. This pull request has now been integrated. Changeset: 679faa69 Author:Claes Redestad URL: https:/

Re: RFR: 8257913: Add more known library locations to simplify Linux cross-compilation [v3]

2021-03-08 Thread Magnus Ihse Bursie
On Fri, 5 Mar 2021 16:03:18 GMT, Aleksey Shipilev wrote: >> Current cross-compilation configurations require adding the whole lot of >> configure options to make it find the dependencies: freetype and X11 libs >> are the only problematic dependencies. We should be able to specify just the >> `

Re: RFR: 8257913: Add more known library locations to simplify Linux cross-compilation [v3]

2021-03-08 Thread Aleksey Shipilev
On Mon, 8 Mar 2021 16:11:20 GMT, Magnus Ihse Bursie wrote: >> Aleksey Shipilev has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Replace with linux with TARGET_OS > > make/autoconf/platform.m4 line 364: > >> 362: AC_SUBST(OPENJDK_TARGET

Integrated: JDK-8251210: Link JDK api docs to other versions

2021-03-08 Thread Jonathan Gibbons
On Sat, 6 Mar 2021 02:21:00 GMT, Jonathan Gibbons wrote: > Please review a small change to Docs.gmk, such that the short version string > in the upper right corner of the main API docs bundle is linked to a page > that links to other versions of the documentation. While it is not so useful >

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-08 Thread Sergey Bylokhov
On Mon, 8 Mar 2021 07:46:54 GMT, Yasumasa Suenaga wrote: >> src/jdk.accessibility/windows/native/common/AccessBridgeDebug.cpp line 80: >> >>> 78: uli.LowPart = ft.dwLowDateTime; >>> 79: uli.HighPart = ft.dwHighDateTime; >>> 80: return (uli.QuadPart / 1ULL) - 1164447360ULL; //

Re: RFR: 8257913: Add more known library locations to simplify Linux cross-compilation [v3]

2021-03-08 Thread Magnus Ihse Bursie
On Mon, 8 Mar 2021 16:14:21 GMT, Aleksey Shipilev wrote: >> make/autoconf/platform.m4 line 364: >> >>> 362: AC_SUBST(OPENJDK_TARGET_CPU_AUTOCONF) >>> 363: AC_SUBST(OPENJDK_TARGET_LIBC) >>> 364: AC_SUBST(OPENJDK_TARGET_ABI) >> >> I realize this has already been integrated, but I don't full

Re: RFR: 8263136: C4530 was reported from VS 2019 at access bridge [v2]

2021-03-08 Thread Yasumasa Suenaga
On Mon, 8 Mar 2021 19:30:17 GMT, Sergey Bylokhov wrote: >> It seems to be fine not to use UNIX epoch at first glance as long as we can >> know the timing of events, but I'm not sure (Thus I rewrote to comply with >> the original code). So I want to hear from the others. > > Did you check via so