Re: RFR: 8262501: jdk17 libjvm link failure with --as-needed and clock_gettime in librt

2021-04-15 Thread Erik Joelsson
On Wed, 14 Apr 2021 23:32:32 GMT, David Holmes wrote: > The fix for JDK-8246112 put the -lrt link flag in the wrong place, causing it > to appear too early in the linker command-line. This changes puts it in the > right place. > > Contributed by: Matthias Klose (~doko) > > Testing: >- l

Integrated: 8262501: jdk17 libjvm link failure with --as-needed and clock_gettime in librt

2021-04-15 Thread David Holmes
On Wed, 14 Apr 2021 23:32:32 GMT, David Holmes wrote: > The fix for JDK-8246112 put the -lrt link flag in the wrong place, causing it > to appear too early in the linker command-line. This changes puts it in the > right place. > > Contributed by: Matthias Klose (~doko) > > Testing: >- l

Re: RFR: 8262501: jdk17 libjvm link failure with --as-needed and clock_gettime in librt

2021-04-15 Thread David Holmes
On Wed, 14 Apr 2021 23:32:32 GMT, David Holmes wrote: > The fix for JDK-8246112 put the -lrt link flag in the wrong place, causing it > to appear too early in the linker command-line. This changes puts it in the > right place. > > Contributed by: Matthias Klose (~doko) > > Testing: >- l

Re: [11u] RFR(M): 8233787 backport: Break cycle in vm_version* includes

2021-04-15 Thread Schmidt, Lutz
Dear all, would somebody please be willing to sponsor this backport patch? Thank you, Lutz On 14.04.21, 19:05, "jdk-updates-dev on behalf of Schmidt, Lutz" wrote: Thanks for reviewing, Paul! Best, Lutz On 14.04.21, 19:01, "Hohensee, Paul" wrote: Lgtm. Th

RE: [11u] RFR(M): 8233787 backport: Break cycle in vm_version* includes

2021-04-15 Thread Hohensee, Paul
I'll sponsor. -Original Message- From: "Schmidt, Lutz" Date: Thursday, April 15, 2021 at 7:16 AM To: "Hohensee, Paul" , "jdk-updates-...@openjdk.java.net" Cc: build-dev Subject: RE: [11u] RFR(M): 8233787 backport: Break cycle in vm_version* includes Dear all, would somebody please b

Re: [11u] RFR(M): 8233787 backport: Break cycle in vm_version* includes

2021-04-15 Thread Hohensee, Paul
Pushed. -Original Message- From: jdk-updates-dev on behalf of "Hohensee, Paul" Date: Thursday, April 15, 2021 at 10:55 AM To: "Schmidt, Lutz" , "jdk-updates-...@openjdk.java.net" Cc: build-dev Subject: RE: [11u] RFR(M): 8233787 backport: Break cycle in vm_version* includes I'll spo

Integrated: 8258794: Support for CLDR version 39

2021-04-15 Thread Naoto Sato
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote: > Please review the changes to support CLDR version 39. The vast majority of > the changes are purely data changes from Unicode. The only change affected in > logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with > CLDR'

RFR: 8260517: implement Sealed Classes as a standard feature

2021-04-15 Thread Vicente Romero
Please review this PR that intents to make sealed classes a final feature in Java. This PR contains compiler and VM changes. In line with similar PRs, which has made preview features final, this one is mostly removing preview related comments from APIs plus options in test cases. Thanks --

Re: RFR: 8260517: implement Sealed Classes as a standard feature in Java [v2]

2021-04-15 Thread David Holmes
On Fri, 16 Apr 2021 02:11:10 GMT, Vicente Romero wrote: >> Please review this PR that intents to make sealed classes a final feature in >> Java. This PR contains compiler and VM changes. In line with similar PRs, >> which has made preview features final, this one is mostly removing preview >>

Re: RFR: 8260517: implement Sealed Classes as a standard feature in Java [v2]

2021-04-15 Thread Vicente Romero
> Please review this PR that intents to make sealed classes a final feature in > Java. This PR contains compiler and VM changes. In line with similar PRs, > which has made preview features final, this one is mostly removing preview > related comments from APIs plus options in test cases. Please

Re: RFR: 8260517: implement Sealed Classes as a standard feature in Java [v2]

2021-04-15 Thread Vicente Romero
On Fri, 16 Apr 2021 02:10:05 GMT, David Holmes wrote: > Hi Vicente, > > Hotspot and hotspot tests all look fine. One query: why was this test removed? > > test/hotspot/jtreg/runtime/sealedClasses/AbstractSealedTest.java > > is that functionality tested elsewhere? (The other deleted test seemed

Re: RFR: 8260517: implement Sealed Classes as a standard feature in Java [v3]

2021-04-15 Thread Vicente Romero
> Please review this PR that intents to make sealed classes a final feature in > Java. This PR contains compiler and VM changes. In line with similar PRs, > which has made preview features final, this one is mostly removing preview > related comments from APIs plus options in test cases. Please