Re: RFR: 8265531: doc/building.md should mention homebrew install freetype

2021-04-23 Thread George Adams
On Thu, 22 Apr 2021 16:12:24 GMT, Erik Joelsson wrote: >> Updates the docs/building.html guide to include steps to install FreeType on >> macOS using homebrew. > > Marked as reviewed by erikj (Reviewer). @erikj79 are you happy to sponsor this PR? - PR: https://git.openjdk.java.net

Re: RFR: 8265531: doc/building.md should mention homebrew install freetype

2021-04-23 Thread Erik Joelsson
On Tue, 20 Apr 2021 14:58:02 GMT, George Adams wrote: > Updates the docs/building.html guide to include steps to install FreeType on > macOS using homebrew. Sure, you need to initiate with the integrate command though. - PR: https://git.openjdk.java.net/jdk/pull/3590

Re: RFR: 8265403: consolidate definition of CPU features [v4]

2021-04-23 Thread Ioi Lam
On Mon, 19 Apr 2021 19:56:45 GMT, Doug Simon wrote: >> While porting >> [JDK-8224974](https://bugs.openjdk.java.net/browse/JDK-8224974) to Graal, I >> noticed that new CPU features were defined for x86 and AArch64 without being >> exposed via JVMCI. To avoid this problem in future, this PR upd

Integrated: 8265531: doc/building.md should mention homebrew install freetype

2021-04-23 Thread George Adams
On Tue, 20 Apr 2021 14:58:02 GMT, George Adams wrote: > Updates the docs/building.html guide to include steps to install FreeType on > macOS using homebrew. This pull request has now been integrated. Changeset: 5aab1609 Author:George Adams Committer: Erik Joelsson URL: https://git

Re: RFR: 8265403: consolidate definition of CPU features [v4]

2021-04-23 Thread Doug Simon
On Mon, 19 Apr 2021 20:01:46 GMT, Vladimir Kozlov wrote: >> Doug Simon has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - updated date in copyright >> - added blank lines after macros > > You need review from Runtime group too. Thanks f

Integrated: 8265403: consolidate definition of CPU features

2021-04-23 Thread Doug Simon
On Sat, 17 Apr 2021 20:18:31 GMT, Doug Simon wrote: > While porting [JDK-8224974](https://bugs.openjdk.java.net/browse/JDK-8224974) > to Graal, I noticed that new CPU features were defined for x86 and AArch64 > without being exposed via JVMCI. To avoid this problem in future, this PR > updates