RFR: 8265666: Enable AIX build platform to make external debug symbols

2021-04-28 Thread Andrew Leonard
Signed-off-by: Andrew Leonard - Commit messages: - 8265666: Enable AIX build platform to make external debug symbols Changes: https://git.openjdk.java.net/jdk/pull/3763/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=3763&range=00 Issue: https://bugs.openjdk.java.net

Re: RFR: 8265666: Enable AIX build platform to make external debug symbols

2021-04-28 Thread Andrew Leonard
This change simply enables the specification of configure args to build external AIX debug symbols: --with-native-debug-symbols=external/zipped Now that we build using XLC/xlclang++ v16+ which supports standard external .debuginfo generation, it is simply a matter of enabling the option for AIX,

Re: RFR: 8265666: Enable AIX build platform to make external debug symbols

2021-04-28 Thread Erik Joelsson
On Wed, 28 Apr 2021 14:41:26 GMT, Andrew Leonard wrote: > Signed-off-by: Andrew Leonard make/common/NativeCompilation.gmk line 979: > 977: else ifeq ($(call isTargetOs, aix), true) > 978: $1_DEBUGINFO_FILES := > $$($1_SYMBOLS_DIR)/$$($1_NOSUFFIX).debuginfo > 979: $

RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Claes Redestad
I'm not exactly sure what I intended to say in this partial comment. Removing it. - Commit messages: - Incomplete comment in build.tools.generatecharacter.GenerateCharacter Changes: https://git.openjdk.java.net/jdk/pull/3766/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk

Re: RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Erik Joelsson
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. Marked as reviewed by erikj (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3766

Re: RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Naoto Sato
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. Marked as reviewed by naoto (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3766

Re: RFR: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Iris Clark
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. Marked as reviewed by iris (Reviewer). - PR: https://git.openjdk.java.net/jdk/pull/3766

Re: RFR: 8265666: Enable AIX build platform to make external debug symbols

2021-04-28 Thread Andrew Leonard
On Wed, 28 Apr 2021 15:14:24 GMT, Erik Joelsson wrote: >> Signed-off-by: Andrew Leonard > > make/common/NativeCompilation.gmk line 979: > >> 977: else ifeq ($(call isTargetOs, aix), true) >> 978: $1_DEBUGINFO_FILES := >> $$($1_SYMBOLS_DIR)/$$($1_NOSUFFIX).debuginfo >> 979:

Re: RFR: 8265666: Enable AIX build platform to make external debug symbols [v2]

2021-04-28 Thread Andrew Leonard
> Signed-off-by: Andrew Leonard Andrew Leonard has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains one new commit since the last revision: 8

Re: RFR: 8265666: Enable AIX build platform to make external debug symbols [v2]

2021-04-28 Thread Andrew Leonard
On Wed, 28 Apr 2021 17:00:13 GMT, Andrew Leonard wrote: >> make/common/NativeCompilation.gmk line 982: >> >>> 980: >>> 981: else ifeq ($(call isTargetOs, macosx), true) >>> 982: $1_DEBUGINFO_FILES := \ >> >> This looks like you are just copying the linked binary and calling i

Re: RFR: 8265666: Enable AIX build platform to make external debug symbols [v2]

2021-04-28 Thread Erik Joelsson
On Wed, 28 Apr 2021 17:23:18 GMT, Andrew Leonard wrote: >> Signed-off-by: Andrew Leonard > > Andrew Leonard has refreshed the contents of this pull request, and previous > commits have been removed. The incremental views will show differences > compared to the previous content of the PR. The p

Re: RFR: 8265666: Enable AIX build platform to make external debug symbols [v2]

2021-04-28 Thread Erik Joelsson
On Wed, 28 Apr 2021 17:43:39 GMT, Andrew Leonard wrote: >> You're essentially correct Erik, on AIX there is no such tool as OBJCOPY on >> Linux platforms, so you cannot physically remove the symbolic information >> from the native compiled object. So this CREATE_DEBUG_INFO_CMDS copies the >> o

Integrated: 8264678: Incomplete comment in build.tools.generatecharacter.GenerateCharacter

2021-04-28 Thread Claes Redestad
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote: > I'm not exactly sure what I intended to say in this partial comment. Removing > it. This pull request has now been integrated. Changeset: 9df6cc7c Author:Claes Redestad URL: https://git.openjdk.java.net/jdk/commit/9df6cc7cc2

Re: RFR: 8265783: Create a separate library for x86 Intel SVML assembly intrinsics [v2]

2021-04-28 Thread Sandhya Viswanathan
> Intel Short Vector Math Library (SVML) based intrinsics in native x86 > assembly provide optimized implementation for Vector API transcendental and > trigonometric methods. > These methods are built into a separate library instead of being part of > libjvm.so or jvm.dll. > > The following cha