Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v11]

2021-06-04 Thread Jan Lahoda
> This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html > > A

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v11]

2021-06-04 Thread Maurizio Cimadamore
On Fri, 4 Jun 2021 09:01:27 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >> http://cr.openjdk.java.net/~gbierman/je

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Jan Lahoda
> This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html > > A

Integrated: 8268129: LibraryLookup::ofDefault leaks symbols from loaded libraries

2021-06-04 Thread Maurizio Cimadamore
On Wed, 2 Jun 2021 17:19:06 GMT, Maurizio Cimadamore wrote: > This patch overhauls the library loading mechanism used by the Foreign Linker > API. We realized that, while handy, the *default* lookup abstraction > (`LibraryLookup::ofDefault`) was behaving inconsistentlt across platforms. > > T

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Paul Sandoz
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >> http://cr.openjdk.java.net/~gbierman/je

Re: RFR: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs

2021-06-04 Thread Lance Andersen
On Fri, 4 Jun 2021 15:53:42 GMT, Weijun Wang wrote: > Now that the default behavior of JDK 17 is still > `-Djava.security.manager=allow`, we can remove the > `-Djavatest.security.noSecurityManager=true` option from the jtreg command > line inside `RunTests.gmk`. Three problem-listed langtools

RFR: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs

2021-06-04 Thread Weijun Wang
Now that the default behavior of JDK 17 is still `-Djava.security.manager=allow`, we can remove the `-Djavatest.security.noSecurityManager=true` option from the jtreg command line inside `RunTests.gmk`. Three problem-listed langtools tests can also be liberated. - Commit messages:

Re: RFR: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs

2021-06-04 Thread Jonathan Gibbons
On Fri, 4 Jun 2021 15:53:42 GMT, Weijun Wang wrote: > Now that the default behavior of JDK 17 is still > `-Djava.security.manager=allow`, we can remove the > `-Djavatest.security.noSecurityManager=true` option from the jtreg command > line inside `RunTests.gmk`. Three problem-listed langtools

Re: RFR: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs

2021-06-04 Thread Weijun Wang
On Fri, 4 Jun 2021 16:10:02 GMT, Jonathan Gibbons wrote: >> Now that the default behavior of JDK 17 is still >> `-Djava.security.manager=allow`, we can remove the >> `-Djavatest.security.noSecurityManager=true` option from the jtreg command >> line inside `RunTests.gmk`. Three problem-listed l

Re: RFR: 8268267: Remove -Djavatest.security.noSecurityManager=true from jtreg runs

2021-06-04 Thread Erik Joelsson
On Fri, 4 Jun 2021 15:53:42 GMT, Weijun Wang wrote: > Now that the default behavior of JDK 17 is still > `-Djava.security.manager=allow`, we can remove the > `-Djavatest.security.noSecurityManager=true` option from the jtreg command > line inside `RunTests.gmk`. Three problem-listed langtools

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Mandy Chung
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >> http://cr.openjdk.java.net/~gbierman/je

RFR: 8268272: Remove JDK-8264874 changes because Graal was removed.

2021-06-04 Thread Vladimir Kozlov
JDK-8264806 removed Graal sources from JDK and INCLUDE_GRAAL is not defined anymore. We can now remove code added by JDK-8264874: https://github.com/openjdk/jdk/commit/951f277a Tested Tier1. - Commit messages: - 8268272: Remove JDK-8264874 changes because Graal was removed. Chang

Re: RFR: 8268272: Remove JDK-8264874 changes because Graal was removed.

2021-06-04 Thread Erik Joelsson
On Fri, 4 Jun 2021 17:40:48 GMT, Vladimir Kozlov wrote: > JDK-8264806 removed Graal sources from JDK and INCLUDE_GRAAL is not defined > anymore. We can now remove code added by JDK-8264874: > https://github.com/openjdk/jdk/commit/951f277a > > Tested Tier1. Marked as reviewed by erikj (Reviewe

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Vicente Romero
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >> http://cr.openjdk.java.net/~gbierman/je

Integrated: 8268272: Remove JDK-8264874 changes because Graal was removed.

2021-06-04 Thread Vladimir Kozlov
On Fri, 4 Jun 2021 17:40:48 GMT, Vladimir Kozlov wrote: > JDK-8264806 removed Graal sources from JDK and INCLUDE_GRAAL is not defined > anymore. We can now remove code added by JDK-8264874: > https://github.com/openjdk/jdk/commit/951f277a > > Tested Tier1. This pull request has now been integ

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Jan Lahoda
On Fri, 4 Jun 2021 09:46:31 GMT, Jan Lahoda wrote: >> This is a preview of a patch implementing JEP 406: Pattern Matching for >> switch (Preview): >> https://bugs.openjdk.java.net/browse/JDK-8213076 >> >> The current draft of the specification is here: >> http://cr.openjdk.java.net/~gbierman/je

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v13]

2021-06-04 Thread Jan Lahoda
> This is a preview of a patch implementing JEP 406: Pattern Matching for > switch (Preview): > https://bugs.openjdk.java.net/browse/JDK-8213076 > > The current draft of the specification is here: > http://cr.openjdk.java.net/~gbierman/jep406/jep406-20210430/specs/patterns-switch-jls.html > > A

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Jan Lahoda
On Fri, 4 Jun 2021 15:46:32 GMT, Paul Sandoz wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing typo. > > test/langtools/tools/javac/patterns/DisambiguateParenthesizedPattern.java > line 72: > >> 70: Sw

Re: RFR: 8262891: Compiler implementation for Pattern Matching for switch (Preview) [v12]

2021-06-04 Thread Jan Lahoda
On Fri, 4 Jun 2021 18:23:28 GMT, Vicente Romero wrote: >> Jan Lahoda has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fixing typo. > > test/langtools/tools/javac/patterns/SealedTypeChanges.java line 71: > >> 69: } >> 70: >> 71: sealed i

Re: RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered

2021-06-04 Thread Dalibor Topic
On Tue, 1 Jun 2021 20:00:07 GMT, jtfuller111 wrote: > Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming > now works as expected. Hi, please send an e-mail to dalibor.to...@oracle.com so that I can mark your account as verified. - PR: https://git.openjd

RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered

2021-06-04 Thread jtfuller111
Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming now works as expected. - Commit messages: - IGV: Zooming now preserves the point currently centered Changes: https://git.openjdk.java.net/jdk/pull/4291/files Webrev: https://webrevs.openjdk.java.net/?repo

RFR: 8268083: JDK-8267706 breaks bin/idea.sh on a Mac

2021-06-04 Thread Nikita Gubarkov
I got rid of `realpath` usage as discussed in https://github.com/openjdk/jdk/pull/4190 and used `RelativePath` macro instead, however there were quite a few problems with this macro, here's the example: $(call RelativePath,/foo/bar,/foo/bar/baz) -> "..//foo/bar" $(call RelativePath,/foo/bar/

Re: RFR: 8268083: JDK-8267706 breaks bin/idea.sh on a Mac

2021-06-04 Thread Erik Joelsson
On Fri, 4 Jun 2021 21:23:27 GMT, Nikita Gubarkov wrote: > I got rid of `realpath` usage as discussed in > https://github.com/openjdk/jdk/pull/4190 and used `RelativePath` macro > instead, however there were quite a few problems with this macro, here's the > example: > > $(call RelativePath,/