Github Action CI pipeline

Hi, I'm interested in the panama project (foreign branch actually) and given my background with Gradle, I also got myself into a plugin to easier and smooth the usage of jextract for us (lib) devs. I played with the current implementation for Github Action in the last days (https://github.com/ele

Re: [jdk17] RFR: 8268861: Disable Windows-Aarch64 build in GitHub Actions [v3]

On Wed, 16 Jun 2021 04:53:08 GMT, David Holmes wrote: >> This has been failing for a while so disabling it until it can be fixed. >> >> Thanks, >> David > > David Holmes has updated the pull request incrementally with one additional > commit since the last revision: > > Completely remove win

[jdk17] RFR: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails

Upstream a critical fix from the panama-foreign repo. See the prior review thread here: https://github.com/openjdk/panama-foreign/pull/558 Testing: tier 1-2, local run of run-test-jdk_foreign. - Commit messages: - Fix a couple of CI build problems - Upstream: 8268673: Stack walk

[jdk17] Integrated: 8268861: Disable Windows-Aarch64 build in GitHub Actions

On Wed, 16 Jun 2021 04:34:09 GMT, David Holmes wrote: > This has been failing for a while so disabling it until it can be fixed. > > Thanks, > David This pull request has now been integrated. Changeset: 19f5fab1 Author:David Holmes URL: https://git.openjdk.java.net/jdk17/commit/19f

Re: RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered [v2]

> Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming > now works as expected. jtfuller111 has updated the pull request incrementally with one additional commit since the last revision: Zooming now actually keeps the current centered point in the center -

Re: [jdk17] RFR: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails

On Wed, 16 Jun 2021 11:19:37 GMT, Jorn Vernee wrote: > Upstream a critical fix from the panama-foreign repo. > > See the prior review thread here: > https://github.com/openjdk/panama-foreign/pull/558 > > Testing: tier 1-2, local run of run-test-jdk_foreign. I've approved a similar changeset o

Re: RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered

On Thu, 10 Jun 2021 20:49:06 GMT, jtfuller111 wrote: >> Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming >> now works as expected. > > Hello, could anyone kindly take a look at this? > Hi @jtfuller111, > > I've tested the fix and found that it eliminates the random

[jdk17] RFR: 8268901: JDK-8268768 missed removing two files

JDK-8268768 reverted a couple putbacks that changed the way the idea projects are generated. Two new template files from JDK-8267706 were missed, and will be removed in this fix. See original bug for further details. - Commit messages: - 8268901: JDK-8268768 missed removing two

Re: [jdk17] RFR: 8268901: JDK-8268768 missed removing two files

On Wed, 16 Jun 2021 16:16:51 GMT, Bradford Wetmore wrote: > JDK-8268768 reverted a couple putbacks that changed the way the idea projects > are generated. > > Two new template files from JDK-8267706 were missed, and will be removed in > this fix. > > See original bug for further details. L

[jdk17] Integrated: 8268901: JDK-8268768 missed removing two files

On Wed, 16 Jun 2021 16:16:51 GMT, Bradford Wetmore wrote: > JDK-8268768 reverted a couple putbacks that changed the way the idea projects > are generated. > > Two new template files from JDK-8267706 were missed, and will be removed in > this fix. > > See original bug for further details. T

Re: Github Action CI pipeline

Hello Giuseppe, Maurizio is correct, we do not publish builds using Github actions. This is not based on a technical limitation, but a general policy in OpenJDK. The current set of Github actions are there to let developers run them in their own repository forks to help them verify their chang

Re: [jdk17] RFR: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails

On Wed, 16 Jun 2021 11:19:37 GMT, Jorn Vernee wrote: > Upstream a critical fix from the panama-foreign repo. > > See the prior review thread here: > https://github.com/openjdk/panama-foreign/pull/558 > > Testing: tier 1-2, local run of run-test-jdk_foreign. Build changes look good. -

Re: RFR: JDK-8263389 IGV: Zooming changes the point that is currently centered [v2]

On Wed, 16 Jun 2021 15:54:14 GMT, jtfuller111 wrote: >> Fixing the zoom issue on IGV. I tested this on Windows and Linux and zooming >> now works as expected. > > jtfuller111 has updated the pull request incrementally with one additional > commit since the last revision: > > Zooming now act

link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)

Hi all, Building OpenJDK on Windows I am faced with the following error ---8<--- os_windows.obj : error LNK2019: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)" (?convert_to_unicode@@YAHPEBDPEAPEA_W@Z) referen

Re: [jdk17] RFR: 8268717: Upstream: 8268673: Stack walk across optimized entry frame on fresh native thread fails

On Wed, 16 Jun 2021 11:19:37 GMT, Jorn Vernee wrote: > Upstream a critical fix from the panama-foreign repo. > > See the prior review thread here: > https://github.com/openjdk/panama-foreign/pull/558 > > Testing: tier 1-2, local run of run-test-jdk_foreign. Hi Jorn, Seems okay but I have one

RFR: Merge jdk17

Forwardport JDK 17 -> JDK 18 - Commit messages: - Merge - 8260194: Update the documentation for -Xcheck:jni - 8268863: ProblemList serviceability/sa/TestJmapCoreMetaspace.java on linux-x64 with ZGC - 8268909: ProblemList jdk/jfr/api/consumer/streaming/TestLatestEvent.java on win

Re: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)

Hi Vitaly, On 17/06/2021 9:47 am, Vitaly Provodin wrote: Hi all, Building OpenJDK on Windows I am faced with the following error ---8<--- os_windows.obj : error LNK2019: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wch

Re: RFR: Merge jdk17 [v2]

> Forwardport JDK 17 -> JDK 18 Jesper Wilhelmsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 35 additional commits since the last revision: - Me

Integrated: Merge jdk17

On Thu, 17 Jun 2021 00:49:27 GMT, Jesper Wilhelmsson wrote: > Forwardport JDK 17 -> JDK 18 This pull request has now been integrated. Changeset: 3637e50b Author:Jesper Wilhelmsson URL: https://git.openjdk.java.net/jdk/commit/3637e50b30e92538510c1a8e8893cedc3bd4ccd5 Stats: 659 l

Re: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)

Hi, I can build current HEAD of upstream (02c9bf087e5) successfully both fastdebug and release build. I use VS 2019 (16.10.1) on WSL 1 Ubuntu 20.04 . Thanks, Yasumasa On 2021/06/17 10:04, David Holmes wrote: Hi Vitaly, On 17/06/2021 9:47 am, Vitaly Provodin wrote: Hi all, Building OpenJ

Re: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)

Hi Yasumasa, On 17/06/2021 11:28 am, Yasumasa Suenaga wrote: Hi, I can build current HEAD of upstream (02c9bf087e5) successfully both fastdebug and release build. I use VS 2019 (16.10.1) on WSL 1 Ubuntu 20.04 . We use 16.9.3 with no problem, but it does seem that the prototype is missing t

Re: link error: unresolved external symbol "int __cdecl convert_to_unicode(char const *,wchar_t * *)

On 2021/06/17 10:31, David Holmes wrote: Hi Yasumasa, On 17/06/2021 11:28 am, Yasumasa Suenaga wrote: Hi, I can build current HEAD of upstream (02c9bf087e5) successfully both fastdebug and release build. I use VS 2019 (16.10.1) on WSL 1 Ubuntu 20.04 . We use 16.9.3 with no problem, but it d