RFR: JDK-8271142: package help is not displayed for missing X11/extensions/Xrandr.h

2021-07-22 Thread Matthias Baesken
Please review the following change. On SUSE Linux 15 configure was running into this error, because of a missing X11 header : checking for X11/extensions/Xrandr.h... no configure: error: Could not find all X11 headers (shape.h Xrender.h Xrandr.h XTest.h Intrinsic.h). I wondered about the missin

RFR: 8271148: static-libs-image target --with-native-debug-symbols=external doesn't produce debug info

2021-07-22 Thread Severin Gehwolf
Hi! Please review this tiny patch which removes the special casing of `--with-native-debug-symbols=external` for the static libs build. I don't see why this is needed. If no debug symbols are wanted `--with-native-debug-symbols=none` can be used to achieve the same effect. Therefore, I propose

Re: RFR: 8271148: static-libs-image target --with-native-debug-symbols=external doesn't produce debug info

2021-07-22 Thread Mikael Vidstedt
On Thu, 22 Jul 2021 16:43:26 GMT, Severin Gehwolf wrote: > Hi! > > Please review this tiny patch which removes the special casing of > `--with-native-debug-symbols=external` for the static libs build. I don't see > why this is needed. If no debug symbols are wanted > `--with-native-debug-symb

Re: RFR: 8271148: static-libs-image target --with-native-debug-symbols=external doesn't produce debug info

2021-07-22 Thread Severin Gehwolf
On Thu, 22 Jul 2021 17:38:28 GMT, Mikael Vidstedt wrote: >> Hi! >> >> Please review this tiny patch which removes the special casing of >> `--with-native-debug-symbols=external` for the static libs build. I don't >> see why this is needed. If no debug symbols are wanted >> `--with-native-debu

Re: [jdk17] RFR: 8269037: jsig/Testjsig.java doesn't have to be restricted to linux only

2021-07-22 Thread Mikhailo Seledtsov
On Sun, 20 Jun 2021 11:08:21 GMT, Igor Ignatyev wrote: > Hi all, > > could you please review this small patch that enables > `runtime/jsig/Testjsig.java` test and compilation of its native library on > all platforms but windows? > from JBS: >> `runtime/jsig/Testjsig.java` test currently `@requ

Withdrawn: 8267312: Resolve should use generated diagnostic factories

2021-07-22 Thread duke
On Tue, 18 May 2021 11:07:18 GMT, Maurizio Cimadamore wrote: > This patch allows Resolve to use more static diagnostic factories. Resolution > errors support generation of diagnostics. This generation is very flexible > and allows creating either a toplevel (error or warning) diagnostic, or a