RFR: 8274559: JFR: Typo in 'jfr help configure' text

2021-10-04 Thread Erik Gahlin
Hi, Could I have review of a typo. Testing: jdk/jdk/jfr Thanks Erik - Commit messages: - Initial Changes: https://git.openjdk.java.net/jdk/pull/5803/files Webrev: https://webrevs.openjdk.java.net/?repo=jdk&pr=5803&range=00 Issue: https://bugs.openjdk.java.net/browse/JDK-82745

RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Richard Reingruber
The following sentence in the JDWP Specification describing the Dispose command confuses resume with suspend [1]: All threads suspended by the thread-level **resume** command or the VM-level **resume** command are resumed as many times as necessary for them to run. It should be changed to

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Alan Bateman
On Mon, 4 Oct 2021 13:44:44 GMT, Richard Reingruber wrote: > The following sentence in the JDWP Specification describing the Dispose > command confuses resume with suspend [1]: > > All threads suspended by the thread-level **resume** command or the VM-level > **resume** command are resumed

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Richard Reingruber
On Mon, 4 Oct 2021 14:22:50 GMT, Alan Bateman wrote: > > > It looks like this typo goes all the way back to JDK 1.2 but was not noticed. Thanks for reviewing. JDK 1.2 is surely long ago. Nevertheless not too many will have read that sentence since then I reckon ;) - PR: https://

Integrated: 8274658: ISO 4217 Amendment 170 Update

2021-10-04 Thread Naoto Sato
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote: > This is to incorporate the ISO 4217 amendment #170, which has been released > today, effective immediately. This pull request has now been integrated. Changeset: f2404d60 Author:Naoto Sato URL: https://git.openjdk.java.net/jdk/co

Integrated: 8274610: Add linux-aarch64 to bootcycle build profiles

2021-10-04 Thread Mikhailo Seledtsov
On Thu, 30 Sep 2021 22:01:51 GMT, Mikhailo Seledtsov wrote: > Please review this simple/trivial change that add linux-aarch64 platform to > bootcycle build profiles. This pull request has now been integrated. Changeset: 9914e5c4 Author:Mikhailo Seledtsov URL: https://git.openjdk.j

Re: RFR: 8274610: Add linux-aarch64 to bootcycle build profiles

2021-10-04 Thread Mikhailo Seledtsov
On Thu, 30 Sep 2021 22:01:51 GMT, Mikhailo Seledtsov wrote: > Please review this simple/trivial change that add linux-aarch64 platform to > bootcycle build profiles. Thank you Erik. - PR: https://git.openjdk.java.net/jdk/pull/5783

Re: RFR: 8274716: JDWP Spec: the description for the Dispose command confuses suspend with resume.

2021-10-04 Thread Chris Plummer
On Mon, 4 Oct 2021 13:44:44 GMT, Richard Reingruber wrote: > The following sentence in the JDWP Specification describing the Dispose > command confuses resume with suspend [1]: > > All threads suspended by the thread-level **resume** command or the VM-level > **resume** command are resumed

Re: RFR: 8274329: Fix non-portable HotSpot code in MethodMatcher::parse_method_pattern

2021-10-04 Thread Ioi Lam
On Sun, 26 Sep 2021 09:55:00 GMT, Jie Fu wrote: > Hi all, > > I tried to build OpenJDK on Cygwin (Windows 2016 + VS2019). > However, I failed with C4474 and C4778 warnings as below: > > Compiling 100 properties into resource bundles for java.desktop > Compiling 3038 files for java.base > e:\jie