Re: RFR: 8275405: Linking error for classes with lambda template parameters and virtual functions [v2]

2021-10-21 Thread Stefan Karlsson
On Wed, 20 Oct 2021 12:23:28 GMT, Stefan Karlsson wrote: >> We encountered the following linking error when trying to build Generational >> ZGC on Windows: >> >> jvm.exp : error LNK2001: unresolved external symbol "const >> ZBasicOopIterateClosure >> >::`vftable'" >> (??_7?$ZBasicOopIterateC

Integrated: 8275405: Linking error for classes with lambda template parameters and virtual functions

2021-10-21 Thread Stefan Karlsson
On Wed, 20 Oct 2021 08:11:34 GMT, Stefan Karlsson wrote: > We encountered the following linking error when trying to build Generational > ZGC on Windows: > > jvm.exp : error LNK2001: unresolved external symbol "const > ZBasicOopIterateClosure > >::`vftable'" > (??_7?$ZBasicOopIterateClosure@

Re: RFR: 8275569: Add linux-aarch64 to test-make profiles

2021-10-21 Thread Magnus Ihse Bursie
On Wed, 20 Oct 2021 18:46:14 GMT, Mikhailo Seledtsov wrote: > Please review this trivial change that adds "linux-aarch64" to test make > profile. Marked as reviewed by ihse (Reviewer). I assume the tests are passing on aarch64. - PR: https://git.openjdk.java.net/jdk/pull/6051

Re: RFR: 8275063: Implementation of Foreign Function & Memory API (Second incubator) [v9]

2021-10-21 Thread Maurizio Cimadamore
> This PR contains the API and implementation changes for JEP-419 [1]. A more > detailed description of such changes, to avoid repetitions during the review > process, is included as a separate comment. > > [1] - https://openjdk.java.net/jeps/419 Maurizio Cimadamore has updated the pull request

Re: RFR: 8275569: Add linux-aarch64 to test-make profiles

2021-10-21 Thread Mikhailo Seledtsov
On Wed, 20 Oct 2021 18:46:14 GMT, Mikhailo Seledtsov wrote: > Please review this trivial change that adds "linux-aarch64" to test make > profile. Magnus, thank you for review. The test make build passes on linux-aarch64. - PR: https://git.openjdk.java.net/jdk/pull/6051

Integrated: 8275569: Add linux-aarch64 to test-make profiles

2021-10-21 Thread Mikhailo Seledtsov
On Wed, 20 Oct 2021 18:46:14 GMT, Mikhailo Seledtsov wrote: > Please review this trivial change that adds "linux-aarch64" to test make > profile. This pull request has now been integrated. Changeset: af146501 Author:Mikhailo Seledtsov URL: https://git.openjdk.java.net/jdk/commit/a

Re: Unable to build Client/Server variant for OpenJDK-11 on ARMv7-A

2021-10-21 Thread John Cummings
Thank you again, that solved that problem, and now another has arose. It can run and compile on our embedded system, but sound no longer functions and I'm now at the point where I need to ask for help again. Running the same code on Java 8 sound works with no errors, running it on the newly buil

Re: RFR: 8275745: Reproducible copyright headers

2021-10-21 Thread Emmanuel Bourg
On Sat, 28 Nov 2020 23:14:35 GMT, Emmanuel Bourg wrote: > The copyright headers are generated at build time, and the year inserted in > the template depends on the current date. This means the headers are not > reproducible if the project is built a year later. The year in the headers > could

RFR: 8275745: Reproducible copyright headers

2021-10-21 Thread Emmanuel Bourg
The copyright headers are generated at build time, and the year inserted in the template depends on the current date. This means the headers are not reproducible if the project is built a year later. The year in the headers could be derived from the SOURCE_DATE_EPOCH environment variable to make

Re: RFR: 8275745: Reproducible copyright headers

2021-10-21 Thread Yi Yang
On Sat, 28 Nov 2020 23:14:35 GMT, Emmanuel Bourg wrote: > The copyright headers are generated at build time, and the year inserted in > the template depends on the current date. This means the headers are not > reproducible if the project is built a year later. The year in the headers > could

Re: RFR: 8275745: Reproducible copyright headers

2021-10-21 Thread Magnus Ihse Bursie
On Sat, 28 Nov 2020 23:14:35 GMT, Emmanuel Bourg wrote: > The copyright headers are generated at build time, and the year inserted in > the template depends on the current date. This means the headers are not > reproducible if the project is built a year later. The year in the headers > could

Re: RFR: 8275745: Reproducible copyright headers

2021-10-21 Thread Emmanuel Bourg
On Thu, 21 Oct 2021 23:33:35 GMT, Magnus Ihse Bursie wrote: >> The copyright headers are generated at build time, and the year inserted in >> the template depends on the current date. This means the headers are not >> reproducible if the project is built a year later. The year in the headers >