Re: RFR: 8277204: Implementation of JEP 8264130: PAC-RET protection for Linux/AArch64 [v17]

2022-02-04 Thread Alan Hayward
On Thu, 3 Feb 2022 16:49:08 GMT, Alan Hayward wrote: > However, I'm not sure how to add to the release notes - I can't find any > files or a process. Ok, This part I understand now :) - PR: https://git.openjdk.java.net/jdk/pull/6334

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v20]

2022-02-04 Thread Martin Doerr
On Fri, 4 Feb 2022 00:25:43 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After modi

Re: RFR: 8274980: Improve adhoc build version strings [v4]

2022-02-04 Thread TheShermanTanker
On Thu, 3 Feb 2022 12:56:12 GMT, Magnus Ihse Bursie wrote: >> Current adhoc version build strings are not ideal. Some of the problems: >> * A build number of "0" is inserted, which make the version string look >> like it's an official build, at least when not reading carefully >> * The version

Re: RFR: 8274980: Improve adhoc build version strings [v4]

2022-02-04 Thread Aleksey Shipilev
On Fri, 4 Feb 2022 10:00:50 GMT, TheShermanTanker wrote: > If that's the case, I'm wondering if instead of changing > `18-internal+0-adhoc.shade.jdk (18-internal)` to something like > `18-internal-jdk-18+17-80-gcdf89304eaf.shade (18-internal)`, `build 18<+build > number, not required>-internal

Re: RFR: 8274980: Improve adhoc build version strings [v4]

2022-02-04 Thread TheShermanTanker
On Fri, 4 Feb 2022 10:05:09 GMT, Aleksey Shipilev wrote: > > If that's the case, I'm wondering if instead of changing > > `18-internal+0-adhoc.shade.jdk (18-internal)` to something like > > `18-internal-jdk-18+17-80-gcdf89304eaf.shade (18-internal)`, `build > > 18<+build number, not required>-

RFR: 8281262: Windows builds in different directories are not fully reproducible

2022-02-04 Thread Maxim Kartashev
Some dll/exe files end up having absolute path names embedded in them despite the use of `--disable-absolute-paths-in-output` build option. This option effectively translates into adding `-pathmap` to compilation lines, but doesn't (always) achieve the desired effects. The reason for that is in

Re: RFR: 8281262: Windows builds in different directories are not fully reproducible

2022-02-04 Thread Erik Joelsson
On Fri, 4 Feb 2022 10:55:40 GMT, Maxim Kartashev wrote: > Some dll/exe files end up having absolute path names embedded in them despite > the use of `--disable-absolute-paths-in-output` build option. This option > effectively translates into adding `-pathmap` to compilation lines, but > doesn'

Re: RFR: 8281262: Windows builds in different directories are not fully reproducible [v2]

2022-02-04 Thread Maxim Kartashev
> Some dll/exe files end up having absolute path names embedded in them despite > the use of `--disable-absolute-paths-in-output` build option. This option > effectively translates into adding `-pathmap` to compilation lines, but > doesn't (always) achieve the desired effects. The reason for tha

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v20]

2022-02-04 Thread Tyler Steele
On Fri, 4 Feb 2022 00:25:43 GMT, Tyler Steele wrote: >> Just in time for the holidays I have completed an implementation of the JFR >> functionality for AIX. As a side note, this is my first submission to >> OpenJDK 👋 >> >> ### Implementation notes and alternatives considered >> >> After modi

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v20]

2022-02-04 Thread Martin Doerr
On Fri, 4 Feb 2022 16:05:02 GMT, Tyler Steele wrote: > I like the idea of adding the IBM copyright line more judiciously, and only > when the changes I've made are significant. ProblemList.txt, where I've made > a single line change, stands out in my mind as an example of where this line > cou

Re: RFR: 8281262: Windows builds in different directories are not fully reproducible

2022-02-04 Thread Maxim Kartashev
On Fri, 4 Feb 2022 14:57:04 GMT, Erik Joelsson wrote: >> Some dll/exe files end up having absolute path names embedded in them >> despite the use of `--disable-absolute-paths-in-output` build option. This >> option effectively translates into adding `-pathmap` to compilation lines, >> but does

Re: RFR: 8281262: Windows builds in different directories are not fully reproducible [v2]

2022-02-04 Thread Erik Joelsson
On Fri, 4 Feb 2022 15:34:42 GMT, Maxim Kartashev wrote: >> Some dll/exe files end up having absolute path names embedded in them >> despite the use of `--disable-absolute-paths-in-output` build option. This >> option effectively translates into adding `-pathmap` to compilation lines, >> but do

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v19]

2022-02-04 Thread Thomas Stuefe
On Thu, 3 Feb 2022 11:22:02 GMT, Thomas Stuefe wrote: >> Looks good to me, too. I think it is ready for integration assuming all >> change requests were taken care of and tests have passed. > >> Looks good to me, too. I think it is ready for integration assuming all >> change requests were take

Re: RFR: 8281262: Windows builds in different directories are not fully reproducible [v3]

2022-02-04 Thread Maxim Kartashev
> Some dll/exe files end up having absolute path names embedded in them despite > the use of `--disable-absolute-paths-in-output` build option. This option > effectively translates into adding `-pathmap` to compilation lines, but > doesn't (always) achieve the desired effects. The reason for tha

Re: RFR: 8203290: [PPC64, s390] Check functionality of JDK-8199712 (Flight Recorder) [v19]

2022-02-04 Thread Tyler Steele
On Fri, 4 Feb 2022 17:35:37 GMT, Thomas Stuefe wrote: > I think Tyler has no write access to JBS yet. This is correct. > Are all relevant JFR tests part of tier1? I run the tests in `test/jdk/jdk/jfr` as I develop as well, so those have been run whether or not they are part of the tier1 tests

Re: RFR: 8281262: Windows builds in different directories are not fully reproducible [v3]

2022-02-04 Thread Erik Joelsson
On Fri, 4 Feb 2022 18:37:51 GMT, Maxim Kartashev wrote: >> Some dll/exe files end up having absolute path names embedded in them >> despite the use of `--disable-absolute-paths-in-output` build option. This >> option effectively translates into adding `-pathmap` to compilation lines, >> but do