On Thu, 28 Oct 2021 09:34:07 GMT, Magnus Ihse Bursie wrote:
> Current adhoc version build strings are not ideal. Some of the problems:
> * A build number of "0" is inserted, which make the version string look like
> it's an official build, at least when not reading carefully
> * The version st
On Fri, 4 Feb 2022 00:25:43 GMT, Tyler Steele wrote:
>> Just in time for the holidays I have completed an implementation of the JFR
>> functionality for AIX. As a side note, this is my first submission to
>> OpenJDK 👋
>>
>> ### Implementation notes and alternatives considered
>>
>> After modi
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121:
> 119: Class c = Reflection.getCallerClass();
> 120: if (c == null) {
> 121:
On Fri, 11 Feb 2022 20:36:26 GMT, Tim Prinzing wrote:
> JDK-8281000 ClassLoader::registerAsParallelCapable throws NPE if caller is
> null
Build changes LGTM.
-
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7448
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Build changes are OK
-
Marked as reviewed by ihse (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/7447
The print_config.js tool was written for Nashorn. With the removal of Nashorn,
this script serves no function and should be removed.
-
Commit messages:
- 8246033: bin/print_config.js script uses nashorn jjs tool
Changes: https://git.openjdk.java.net/jdk/pull/7464/files
Webrev: htt
On Mon, 14 Feb 2022 10:32:11 GMT, Magnus Ihse Bursie wrote:
>> Tyler Steele has updated the pull request with a new target base due to a
>> merge or a rebase. The pull request now contains ten commits:
>>
>> - Merge branch 'master' into JDK-8203290
>> - Adds Oracle & IBM copyrights as per gui
On Mon, 14 Feb 2022 16:23:20 GMT, Magnus Ihse Bursie wrote:
> The print_config.js tool was written for Nashorn. With the removal of
> Nashorn, this script serves no function and should be removed.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/
On Mon, 14 Feb 2022 11:56:16 GMT, Alan Bateman wrote:
>> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121:
>
>> 119: Class c = Reflection.getCallerClass();
>> 120: if (c == null) {
>> 121
On Mon, 14 Feb 2022 18:03:45 GMT, Mandy Chung wrote:
>> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121:
>>
>>> 119: Class c = Reflection.getCallerClass();
>>> 120: if (c == null) {
>>> 121: throw new IllegalCallerException();
>>
>> Throwing
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
test/jdk/java/lang/invoke/MethodHandles/exeNullCallerMethodHandlesLookup/NullCallerMethodHandlesLookupTest.java
line 2:
> 1: /*
> 2: * Copyright (c) 2019, 2022, Oracle and/
On Mon, 14 Feb 2022 18:28:09 GMT, Mandy Chung wrote:
>> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
>
> src/java.base/share/classes/java/lang/invoke/MethodHandles.java line 121:
>
>> 119: Class c = Reflection.getCallerClass();
>> 120: if (c == null) {
>> 121:
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
This needs a CSR and the spec needs update.
The test name could be shortened to
`s/exeNullCallerMethodHandlesLookup/exeNullCallerLookup/`.
src/java.base/share/classes/jav
On Fri, 11 Feb 2022 20:32:46 GMT, Tim Prinzing wrote:
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Marked as reviewed by jrose (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7447
On Mon, 14 Feb 2022 18:10:37 GMT, Alan Bateman wrote:
>> `MethodHandles::publicLookup` can be called instead to get a public Lookup
>> to invoke a method with a Lookup parameter. The dilemma here is whether
>> the API should be made null-caller friendly or using a proper API
>> `MethodHandle
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
Changes from feedback.
- Improved javadoc.
- Single copyright date in new files.
- Informative string in excep
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
missing dot
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
- new: https://git.ope
> Just in time for the holidays I have completed an implementation of the JFR
> functionality for AIX. As a side note, this is my first submission to OpenJDK
> 👋
>
> ### Implementation notes and alternatives considered
>
> After modifying the build system to allow the --enable-jvm-feature-jfr t
On Mon, 14 Feb 2022 17:11:12 GMT, Thomas Stuefe wrote:
>> make/autoconf/jvm-features.m4 line 3:
>>
>>> 1: #
>>> 2: # Copyright (c) 2011, 2022, Oracle and/or its affiliates. All rights
>>> reserved.
>>> 3: # Copyright (c) 2022, IBM Corp.
>>
>> I understand the discussion about copyright lines h
On Mon, 14 Feb 2022 23:44:40 GMT, Tyler Steele wrote:
>> Just in time for the holidays I have completed an implementation of the JFR
>> functionality for AIX. As a side note, this is my first submission to
>> OpenJDK 👋
>>
>> ### Implementation notes and alternatives considered
>>
>> After mod
> JDK-8281003 - MethodHandles::lookup throws NPE if caller is null
Tim Prinzing has updated the pull request incrementally with one additional
commit since the last revision:
remove excess description
-
Changes:
- all: https://git.openjdk.java.net/jdk/pull/7447/files
- new: h
On 14:09 Thu 10 Feb , Severin Gehwolf wrote:
>
> Latest webrev:
> https://cr.openjdk.java.net/~sgehwolf/webrevs/JDK-8210283/02/webrev/
>
> OK?
>
> Thanks,
> Severin
>
This looks fine. Please flag for approval.
Thanks,
--
Andrew :)
Pronouns: he / him or they / them
Senior Free Java Softwa
22 matches
Mail list logo
