RFR: 8282225: GHA: Allow one concurrent run per PR only

2022-02-22 Thread Aleksey Shipilev
Since last year, GHA allows concurrency control over GHA runs: https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency Our GHA workflows trigger on every PR

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only

2022-02-22 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 07:05:40 GMT, Aleksey Shipilev wrote: > Since last year, GHA allows concurrency control over GHA runs: > > https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ > > https://docs.github.com/en/actions/using-workflows/workflow-syntax-

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-22 Thread Magnus Ihse Bursie
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote: > Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a string literal

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v4]

2022-02-22 Thread Thomas Schatzl
On Tue, 8 Feb 2022 08:17:17 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x

Re: RFR: 8242181: [Linux] Show source information when printing native stack traces in hs_err files [v4]

2022-02-22 Thread Christian Hagedorn
On Tue, 8 Feb 2022 08:17:17 GMT, Christian Hagedorn wrote: >> When printing the native stack trace on Linux (mostly done for hs_err >> files), it only prints the method with its parameters and a relative offset >> in the method: >> >> Stack: [0x7f6e01739000,0x7f6e0183a000], sp=0x

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-22 Thread David Holmes
On Mon, 21 Feb 2022 19:55:14 GMT, Daniel Jeliński wrote: > Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a string literal

Re: RFR: 8277204: Implement PAC-RET branch protection on Linux/AArch64 [v24]

2022-02-22 Thread Alan Hayward
> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One > of its uses is to protect against ROP based attacks. This is done by > signing the Link Register whenever it is stored on the stack, and > authenticating the value when it is loaded back from the stack. If an > attacker were

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build

2022-02-22 Thread Daniel Jeliński
On Tue, 22 Feb 2022 11:33:52 GMT, Magnus Ihse Bursie wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes assigning a string li

Re: RFR: 8277204: Implement PAC-RET branch protection on Linux/AArch64 [v25]

2022-02-22 Thread Alan Hayward
> PAC is an optional feature in AArch64 8.3 and is compulsory in v9. One > of its uses is to protect against ROP based attacks. This is done by > signing the Link Register whenever it is stored on the stack, and > authenticating the value when it is loaded back from the stack. If an > attacker were

RFR: 8244593: Clean up GNM/NM after JEP 381

2022-02-22 Thread Magnus Ihse Bursie
Long overdue follow-up bug from JEP 381 (removal of Solaris support). We used to make a difference between gnm (GNU nm) and nm (GNU nm on all platforms except Solaris, where it were Solaris nm), but this does not make sense anymore, and the code is just schizophrenic wrt nm/gnm. -

Re: RFR: 8244593: Clean up GNM/NM after JEP 381

2022-02-22 Thread Erik Joelsson
On Tue, 22 Feb 2022 15:47:05 GMT, Magnus Ihse Bursie wrote: > Long overdue follow-up bug from JEP 381 (removal of Solaris support). We used > to make a difference between gnm (GNU nm) and nm (GNU nm on all platforms > except Solaris, where it were Solaris nm), but this does not make sense > an

Integrated: 8244593: Clean up GNM/NM after JEP 381

2022-02-22 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 15:47:05 GMT, Magnus Ihse Bursie wrote: > Long overdue follow-up bug from JEP 381 (removal of Solaris support). We used > to make a difference between gnm (GNU nm) and nm (GNU nm on all platforms > except Solaris, where it were Solaris nm), but this does not make sense > an

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only [v2]

2022-02-22 Thread Aleksey Shipilev
> Since last year, GHA allows concurrency control over GHA runs: > > https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ > > https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#concurrency > > Our GHA workflows trigge

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only

2022-02-22 Thread Aleksey Shipilev
On Tue, 22 Feb 2022 07:05:40 GMT, Aleksey Shipilev wrote: > Since last year, GHA allows concurrency control over GHA runs: > > https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ > > https://docs.github.com/en/actions/using-workflows/workflow-syntax-

RFR: 8209784: Include hsdis in the JDK

2022-02-22 Thread Magnus Ihse Bursie
This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting this, together with a valid backend using `--with-hsdis`, will bundle the generated hsdis library with the JDK. The PR also includes a refactoring of the hsdis handling in autoconf, breaking it out to a separate file `lib

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only [v2]

2022-02-22 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 16:18:24 GMT, Aleksey Shipilev wrote: >> Since last year, GHA allows concurrency control over GHA runs: >> >> https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ >> >> https://docs.github.com/en/actions/using-workflows/workflow-sy

Re: RFR: 8209784: Include hsdis in the JDK

2022-02-22 Thread Erik Joelsson
On Tue, 22 Feb 2022 16:10:22 GMT, Magnus Ihse Bursie wrote: > This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting > this, together with a valid backend using `--with-hsdis`, will bundle the > generated hsdis library with the JDK. > > The PR also includes a refactoring of

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Daniel Jeliński
> Please review this PR that enables > [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) > compiler flag, which makes assigning a string literal to a non-const pointer > a compile-time error. > > This t

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 14:13:43 GMT, Daniel Jeliński wrote: >> make/autoconf/flags-cflags.m4 line 136: >> >>> 134: CFLAGS_WARNINGS_ARE_ERRORS="-WX" >>> 135: >>> 136: WARNINGS_ENABLE_ALL="-W3 -Zc:strictStrings" >> >> This is not strictly a flag to enable warnings. I'd recommend you mov

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Daniel Jeliński
On Tue, 22 Feb 2022 16:35:09 GMT, Magnus Ihse Bursie wrote: >> Done > > Did you forget to push the fix? Push works better when connected... this time it's pushed for real. - PR: https://git.openjdk.java.net/jdk/pull/7565

Re: RFR: 8209784: Include hsdis in the JDK

2022-02-22 Thread Andrew Haley
On Tue, 22 Feb 2022 16:10:22 GMT, Magnus Ihse Bursie wrote: > This PR adds a new configure argument, `--enable-hsdis-bundling`. Setting > this, together with a valid backend using `--with-hsdis`, will bundle the > generated hsdis library with the JDK. Maybe I missed it, but are there instructi

Re: RFR: 8209784: Include hsdis in the JDK

2022-02-22 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 16:54:21 GMT, Andrew Haley wrote: > Maybe I missed it, but are there instructions somewhere about how to build > this, and what should be downloaded? See https://github.com/openjdk/jdk/blob/master/src/utils/hsdis/README.md - PR: https://git.openjdk.java.net/jdk

Re: RFR: 8281525: Enable Zc:strictStrings flag in Visual Studio build [v2]

2022-02-22 Thread Magnus Ihse Bursie
On Tue, 22 Feb 2022 16:43:28 GMT, Daniel Jeliński wrote: >> Please review this PR that enables >> [Zc:strictStrings](https://docs.microsoft.com/en-us/cpp/build/reference/zc-strictstrings-disable-string-literal-type-conversion?view=msvc-170) >> compiler flag, which makes assigning a string liter

Re: RFR: 8282225: GHA: Allow one concurrent run per PR only [v2]

2022-02-22 Thread Aleksey Shipilev
On Tue, 22 Feb 2022 16:18:24 GMT, Aleksey Shipilev wrote: >> Since last year, GHA allows concurrency control over GHA runs: >> >> https://github.blog/changelog/2021-04-19-github-actions-limit-workflow-run-or-job-concurrency/ >> >> https://docs.github.com/en/actions/using-workflows/workflow-sy